linux-kernel - Re: [PATCH v2 1/5] arm64: allwinner: h6: orangepi: Add PIO regulators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJiuCccbHg9ig4ZnyCzYAB1AqxCZLqtCF_7gKEiCD+ATwNYD-Q@mail.gmail.com>
Date:   Fri, 5 Apr 2019 18:42:52 +0200
From:   Clément Péron <peron.clem@...il.com>
To:     Maxime Ripard <maxime.ripard@...tlin.com>
Cc:     Rob Herring <robh+dt@...nel.org>, Chen-Yu Tsai <wens@...e.org>,
        Icenowy Zheng <icenowy@...c.io>,
        Jagan Teki <jagan@...rulasolutions.com>,
        devicetree <devicetree@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        linux-sunxi@...glegroups.com
Subject: Re: [PATCH v2 1/5] arm64: allwinner: h6: orangepi: Add PIO regulators

Hi,

On Fri, 5 Apr 2019 at 17:08, Maxime Ripard <maxime.ripard@...tlin.com> wrote:
>
> On Fri, Apr 05, 2019 at 02:24:42PM +0200, Clément Péron wrote:
> > OrangePi One Plus and OrangePi Lite2 use the same PIO regulators.
> >
> > Add this in the common device tree.
> >
> > Signed-off-by: Clément Péron <peron.clem@...il.com>
> > ---
> >  arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi
> > index b2526dac2fcf..fd2af5095425 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi.dtsi
> > @@ -72,6 +72,12 @@
> >       status = "okay";
> >  };
> >
> > +&pio {
> > +        vcc-pc-supply = <&reg_bldo2>;
> > +        vcc-pd-supply = <&reg_cldo1>;
> > +        vcc-pg-supply = <&reg_bldo3>;
> > +};
> > +
> >  &r_i2c {
> >       status = "okay";
> >
> > @@ -191,6 +197,11 @@
> >       };
> >  };
> >
> > +&r_pio {
> > +        vcc-pl-supply = <&reg_aldo1>;
> > +        vcc-pm-supply = <&reg_bldo3>;
> > +};
> > +
>
> How was this tested?
Sorry maybe I should mention that but I don't own an OrangePi or a Pine H64.

But this should have the same issue than the Beelink GS1.

>
> Please run checkpatch on your patches as well.
Thanks for the advice,
Clement

>
> Maxime
>
> --
> Maxime Ripard, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com