linux-kernel - Re: [PATCH] um: Do not unlock mutex that is not hold.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cb5e35f0-9f95-fec1-9325-be8fa580bf00@kot-begemot.co.uk>
Date:   Fri, 5 Apr 2019 17:17:27 +0100
From:   Anton Ivanov <anton.ivanov@...-begemot.co.uk>
To:     Daniel Walter <dwalter@...gle.com>, richard@....at,
        linux-um@...ts.infradead.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] um: Do not unlock mutex that is not hold.



On 02/04/2019 09:43, Daniel Walter wrote:
>   Return error instead of trying to unlock a mutex that is not hold.
> 
> Signed-off-by: Daniel Walter <dwalter@...gle.com>
> ---
>   arch/um/drivers/ubd_kern.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/um/drivers/ubd_kern.c b/arch/um/drivers/ubd_kern.c
> index aca09be2373e..33c1cd6a12ac 100644
> --- a/arch/um/drivers/ubd_kern.c
> +++ b/arch/um/drivers/ubd_kern.c
> @@ -276,14 +276,14 @@ static int ubd_setup_common(char *str, int *index_out, char **error_out)
>   		str++;
>   		if(!strcmp(str, "sync")){
>   			global_openflags = of_sync(global_openflags);
> -			goto out1;
> +			return err;
>   		}
>   
>   		err = -EINVAL;
>   		major = simple_strtoul(str, &end, 0);
>   		if((*end != '\0') || (end == str)){
>   			*error_out = "Didn't parse major number";
> -			goto out1;
> +			return err;
>   		}
>   
>   		mutex_lock(&ubd_lock);
> 

Reviewed-by: Anton Ivanov <anton.ivanov@...bridgegreys.com>
Acked-by: Anton Ivanov <anton.ivanov@...bridgegreys.com>

-- 
Anton R. Ivanov
https://www.kot-begemot.co.uk/