linux-kernel - Re: [PATCH] MT7621-SPI: spi-mt7621: Fix alignment and style problems Fixed Coding function and style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 5 Apr 2019 11:05:26 +0800
From:   Chuanhong Guo <gch981213@...il.com>
To:     Nilesh Hase <nilhase25@...il.com>
Cc:     Matthias Brugger <matthias.bgg@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        NeilBrown <neil@...wn.name>, Stefan Roese <sr@...x.de>,
        sankalpnegi2310@...il.com, devel@...verdev.osuosl.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] MT7621-SPI: spi-mt7621: Fix alignment and style problems
 Fixed Coding function and style issues

Hi!

On Fri, Apr 5, 2019 at 2:53 AM Nilesh Hase <nilhase25@...il.com> wrote:
>
> Fix checkpatch issues: "CHECK: Alignment should match open parenthesis"
>
> Signed-off-by: Nilesh Hase <nilhase25@...il.com>
> ---
>  drivers/staging/mt7621-spi/spi-mt7621.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/mt7621-spi/spi-mt7621.c b/drivers/staging/mt7621-spi/spi-mt7621.c
> index b509f9fe3346..6fa9876f5a92 100644
> --- a/drivers/staging/mt7621-spi/spi-mt7621.c
> +++ b/drivers/staging/mt7621-spi/spi-mt7621.c
FYI This file doesn't exist now. The driver has been moved into
drivers/spi by this commit:
cbd66c626e16 spi: mt7621: Move SPI driver out of staging

It's in linux-next-20190329 and later tags.
> @@ -303,7 +303,7 @@ static int mt7621_spi_setup(struct spi_device *spi)
>         struct mt7621_spi *rs = spidev_to_mt7621_spi(spi);
>
>         if ((spi->max_speed_hz == 0) ||
> -               (spi->max_speed_hz > (rs->sys_freq / 2)))
> +           (spi->max_speed_hz > (rs->sys_freq / 2)))
>                 spi->max_speed_hz = (rs->sys_freq / 2);
>
>         if (spi->max_speed_hz < (rs->sys_freq / 4097)) {
> --
> 2.20.1
>
Regards,
 Chuanhong Guo