lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sat, 6 Apr 2019 14:36:04 +0200
From:   Markus Elfring <>
To:     Himanshu Jha <>,
        Julia Lawall <>
        Andy Shevchenko <>,
        Bartosz Golaszewski <>,
        Gilles Muller <>,
        Greg Kroah-Hartman <>,
        Linus Walleij <>,
        Masahiro Yamada <>,
        Michal Marek <>,
        Nicolas Palix <>
Subject: Re: [PATCH] coccinelle: api: add devm_platform_ioremap_resource

> +// Copyright: (C) 2019 Himanshu Jha GPLv2.

How do you think about to use a SPDX identifier?

> +// ---…

I would prefer a SmPL script without such comment lines as delimiters here.

> +position j0;

Would the variable name “p” be nicer?

> +@...ipt:python depends on report && !patch@
> +e1 << r2.e1;
> +j0 << r2.j0;
> +@@
> +
> +msg = "WARNING: Use devm_platform_ioremap_resource for %s" % (e1)
>[0], msg)

I suggest to print such a message without the extra variable “msg”
because the string format expression can be passed directly.


Powered by blists - more mailing lists