linux-kernel - Re: [PATCH] kprobes: fix compilation when KPROBE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 06 Apr 2019 22:52:47 +0530
From:   "Naveen N. Rao" <naveen.n.rao@...ux.vnet.ibm.com>
To:     linux-kernel@...r.kernel.org, Sven Schnelle <svens@...ckframe.org>
Cc:     Anil S Keshavamurthy <anil.s.keshavamurthy@...el.com>,
        "David S. Miller" <davem@...emloft.net>,
        Masami Hiramatsu <mhiramat@...nel.org>
Subject: Re: [PATCH] kprobes: fix compilation when KPROBE_EVENTS is enabled
 without kretpobes

Sven Schnelle wrote:
> While implementing kprobes on PA-RISC (without kretprobes) compilation
> fails when CONFIG_KPROBE_EVENTS is enabled:

Thanks for working on that! Is there a specific reason kretprobes is not 
being enabled on parisc?

> 
> kernel/trace/trace_kprobe.o: in function `trace_kprobe_create':
> kernel/trace/trace_kprobe.c:666: undefined reference to `kprobe_on_func_entry'
> kernel/trace/trace_kprobe.o: in function `trace_kprobe_on_func_entry':
> kernel/trace/trace_kprobe.c:167: undefined reference to `kprobe_on_func_entry'
> kernel/trace/trace_kprobe.c:167: undefined reference to `kprobe_on_func_entry'
> make: *** [Makefile:1029: vmlinux] Error 1
> 
> Given the fact that these functions have no dependencies on kretprobes i think
> they should be moved out of the #ifdef CONFIG_KRETPROBES block.
> 
> Signed-off-by: Sven Schnelle <svens@...ckframe.org>
> Cc: "Naveen N. Rao" <naveen.n.rao@...ux.ibm.com>
> Cc: Anil S Keshavamurthy <anil.s.keshavamurthy@...el.com>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Masami Hiramatsu <mhiramat@...nel.org>
> ---
>  kernel/kprobes.c | 39 ++++++++++++++++++++-------------------
>  1 file changed, 20 insertions(+), 19 deletions(-)

These functions were originally added only for kretprobes, but have 
taken on newer uses since then. So, for this patch:
Acked-by: Naveen N. Rao <naveen.n.rao@...ux.vnet.ibm.com>

However, I wonder if we should simply remove CONFIG_KRETPROBES 
altogether. All architectures supporting kprobes today also support 
kretprobes. I don't see why anyone would want to only disable 
kretprobes.


- Naveen