linux-kernel - Re: [PATCH] watchdog: machzwd : fix warning Using plain integer as NULL pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 7 Apr 2019 00:17:50 +0530
From:   Mukesh Ojha <mojha@...eaurora.org>
To:     Hariprasad Kelam <hariprasad.kelam@...il.com>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        Guenter Roeck <linux@...ck-us.net>,
        linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] watchdog: machzwd : fix warning Using plain integer as
 NULL pointer


On 4/6/2019 6:44 PM, Hariprasad Kelam wrote:
> Changes passing function argument 0 to NULL to avoid below sparse
> warning
>
>   CHECK   drivers/watchdog//machzwd.c
> drivers/watchdog//machzwd.c:321:25: warning: Using plain integer as NULL
> pointer
> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@...il.com>
Reviewed-by: Mukesh Ojha <mojha@...eaurora.org>

Cheers,
-Mukesh

> ---
>   drivers/watchdog/machzwd.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/machzwd.c b/drivers/watchdog/machzwd.c
> index 88d823d..c3926d0 100644
> --- a/drivers/watchdog/machzwd.c
> +++ b/drivers/watchdog/machzwd.c
> @@ -318,7 +318,7 @@ static long zf_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
>   	case WDIOC_GETBOOTSTATUS:
>   		return put_user(0, p);
>   	case WDIOC_KEEPALIVE:
> -		zf_ping(0);
> +		zf_ping(NULL);
>   		break;
>   	default:
>   		return -ENOTTY;