linux-kernel - Re: [PATCH] xen: xen-pciback: fix warning Using plain integer as NULL pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8d19e62d-11cd-91dc-6c54-d688d2d67d00@codeaurora.org>
Date:   Sun, 7 Apr 2019 00:33:29 +0530
From:   Mukesh Ojha <mojha@...eaurora.org>
To:     Hariprasad Kelam <hariprasad.kelam@...il.com>,
        Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        Juergen Gross <jgross@...e.com>,
        Stefano Stabellini <sstabellini@...nel.org>,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        xen-devel@...ts.xenproject.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] xen: xen-pciback: fix warning Using plain integer as NULL
 pointer


On 4/6/2019 5:59 PM, Hariprasad Kelam wrote:
> Changes passing function argument 0 to NULL to avoid below sparse
> warning
>
>   CHECK   drivers/xen/xen-pciback/xenbus.c
> drivers/xen/xen-pciback/xenbus.c:700:51: warning: Using plain integer as
> NULL pointer
>
> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@...il.com>
Reviewed-by: Mukesh Ojha <mojha@...eaurora.org>

Cheers,
-Mukesh

> ---
>   drivers/xen/xen-pciback/xenbus.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/xen/xen-pciback/xenbus.c b/drivers/xen/xen-pciback/xenbus.c
> index 23f7f6e..833b2d2 100644
> --- a/drivers/xen/xen-pciback/xenbus.c
> +++ b/drivers/xen/xen-pciback/xenbus.c
> @@ -697,7 +697,7 @@ static int xen_pcibk_xenbus_probe(struct xenbus_device *dev,
>   	/* We need to force a call to our callback here in case
>   	 * xend already configured us!
>   	 */
> -	xen_pcibk_be_watch(&pdev->be_watch, NULL, 0);
> +	xen_pcibk_be_watch(&pdev->be_watch, NULL, NULL);
>   
>   out:
>   	return err;