linux-kernel - Re: [PATCH] kernel: pid_namespace : fix warning Using plain integer as NULL pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9af19729-cd8a-c3ec-6e89-1696f338c5c1@codeaurora.org>
Date:   Sun, 7 Apr 2019 00:42:56 +0530
From:   Mukesh Ojha <mojha@...eaurora.org>
To:     Hariprasad Kelam <hariprasad.kelam@...il.com>,
        "Eric W. Biederman" <ebiederm@...ssion.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kernel: pid_namespace : fix warning Using plain integer
 as NULL pointer


On 4/6/2019 4:18 PM, Hariprasad Kelam wrote:
> changed passing function argument "0 to NULL" to fix below sparse
> warning
>
> kernel/pid_namespace.c:55:76: warning: Using plain integer as NULL
> pointer
>
> did changes to avoid checkpatch error "prefer a maximum 75 chars per
> line"
>
> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@...il.com>
Reviewed-by: Mukesh Ojha <mojha@...eaurora.org>

Cheers,
-Mukesh

> ---
>   kernel/pid_namespace.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/pid_namespace.c b/kernel/pid_namespace.c
> index aa6e72f..6e4afdc 100644
> --- a/kernel/pid_namespace.c
> +++ b/kernel/pid_namespace.c
> @@ -52,7 +52,8 @@ static struct kmem_cache *create_pid_cachep(unsigned int level)
>   	mutex_lock(&pid_caches_mutex);
>   	/* Name collision forces to do allocation under mutex. */
>   	if (!*pkc)
> -		*pkc = kmem_cache_create(name, len, 0, SLAB_HWCACHE_ALIGN, 0);
> +		*pkc =
> +		    kmem_cache_create(name, len, 0, SLAB_HWCACHE_ALIGN, NULL);
>   	mutex_unlock(&pid_caches_mutex);
>   	/* current can fail, but someone else can succeed. */
>   	return READ_ONCE(*pkc);