lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20190406.181834.995998216821289412.davem@davemloft.net> Date: Sat, 06 Apr 2019 18:18:34 -0700 (PDT) From: David Miller <davem@...emloft.net> To: colin.king@...onical.com Cc: edumazet@...gle.com, kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org, netdev@...r.kernel.org, kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] tcp: remove redundant check on tskb From: Colin King <colin.king@...onical.com> Date: Thu, 4 Apr 2019 15:46:03 +0100 > From: Colin Ian King <colin.king@...onical.com> > > The non-null check on tskb is always false because it is in an else > path of a check on tskb and hence tskb is null in this code block. > This is check is therefore redundant and can be removed as well > as the label coalesc. > > if (tsbk) { > ... > } else { > ... > if (unlikely(!skb)) { > if (tskb) /* can never be true, redundant code */ > goto coalesc; > return; > } > } > > Addresses-Coverity: ("Logically dead code") > Signed-off-by: Colin Ian King <colin.king@...onical.com> Applied to net-next.
Powered by blists - more mailing lists