lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20190407210541.13409-4-alexandre.belloni@bootlin.com> Date: Sun, 7 Apr 2019 23:05:37 +0200 From: Alexandre Belloni <alexandre.belloni@...tlin.com> To: linux-rtc@...r.kernel.org Cc: linux-kernel@...r.kernel.org, Alexandre Belloni <alexandre.belloni@...tlin.com> Subject: [PATCH 4/8] rtc: ds1672: remove useless indirection ds1672_get_datetime and ds1672_set_mmss are only used after casting dev to an i2c_client. Remove that useless indirection. Signed-off-by: Alexandre Belloni <alexandre.belloni@...tlin.com> --- drivers/rtc/rtc-ds1672.c | 20 ++++++-------------- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/drivers/rtc/rtc-ds1672.c b/drivers/rtc/rtc-ds1672.c index 4b4757a6644d..81f1aaeb8964 100644 --- a/drivers/rtc/rtc-ds1672.c +++ b/drivers/rtc/rtc-ds1672.c @@ -26,8 +26,9 @@ * rtc_time -- month 0-11, hour 0-23, yr = calendar year-epoch * Time is set to UTC. */ -static int ds1672_get_datetime(struct i2c_client *client, struct rtc_time *tm) +static int ds1672_read_time(struct device *dev, struct rtc_time *tm) { + struct i2c_client *client = to_i2c_client(dev); unsigned long time; unsigned char addr = DS1672_REG_CONTROL; unsigned char buf[4]; @@ -83,8 +84,9 @@ static int ds1672_get_datetime(struct i2c_client *client, struct rtc_time *tm) return 0; } -static int ds1672_set_mmss(struct i2c_client *client, unsigned long secs) +static int ds1672_set_mmss(struct device *dev, unsigned long secs) { + struct i2c_client *client = to_i2c_client(dev); int xfer; unsigned char buf[6]; @@ -104,19 +106,9 @@ static int ds1672_set_mmss(struct i2c_client *client, unsigned long secs) return 0; } -static int ds1672_rtc_read_time(struct device *dev, struct rtc_time *tm) -{ - return ds1672_get_datetime(to_i2c_client(dev), tm); -} - -static int ds1672_rtc_set_mmss(struct device *dev, unsigned long secs) -{ - return ds1672_set_mmss(to_i2c_client(dev), secs); -} - static const struct rtc_class_ops ds1672_rtc_ops = { - .read_time = ds1672_rtc_read_time, - .set_mmss = ds1672_rtc_set_mmss, + .read_time = ds1672_read_time, + .set_mmss = ds1672_set_mmss, }; static int ds1672_probe(struct i2c_client *client, -- 2.20.1
Powered by blists - more mailing lists