linux-kernel - Re: [PATCH net] net: vrf: Fix ping failed when vrf mtu is set to 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190406.181232.473436529978209156.davem@davemloft.net>
Date:   Sat, 06 Apr 2019 18:12:32 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     linmiaohe@...wei.com
Cc:     dsa@...ulusnetworks.com, shrijeet@...il.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        mingfangsen@...wei.com
Subject: Re: [PATCH net] net: vrf: Fix ping failed when vrf mtu is set to 0

From: linmiaohe <linmiaohe@...wei.com>
Date: Thu, 4 Apr 2019 20:01:13 +0800

> From: Miaohe Lin <linmiaohe@...wei.com>
> 
> When the mtu of a vrf device is set to 0, it would cause ping
> failed.So I think we should limit dev->min_mtu to ETH_MIN_MTU
> to solve this problem. And if dev->max_mtu still be 0 can be
> confusing, so I limit dev->max_mtu to ETH_MAX_MTU.
> 
> Here is the reproduce step:

Just in case it isn't clear, David Ahern gave you feedback and
asked you to adjust things so that the problem is solved for ipv6
as well.  He also gave you an appropriate Fixes: tag to add to
your commit message.