linux-kernel - Re: [PATCH] iio: adc: ads124: avoid buffer overflow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190407130316.2ff07791@archlinux>
Date:   Sun, 7 Apr 2019 13:03:16 +0100
From:   Jonathan Cameron <jic23@...23.retrosnub.co.uk>
To:     Dan Murphy <dmurphy@...com>
Cc:     Vincent Stehlé <vincent.stehle@...oste.net>,
        <linux-iio@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>
Subject: Re: [PATCH] iio: adc: ads124: avoid buffer overflow

On Sun, 7 Apr 2019 13:02:42 +0100
Jonathan Cameron <jic23@...23.retrosnub.co.uk> wrote:

> On Mon, 1 Apr 2019 07:41:37 -0500
> Dan Murphy <dmurphy@...com> wrote:
> 
> > On 3/31/19 1:54 PM, Vincent Stehlé wrote:  
> > > When initializing the priv->data array starting from index 1, there is one
> > > less element to consider than when initializing the full array.
> > > 
> > > Fixes: e717f8c6dfec8f76 ("iio: adc: Add the TI ads124s08 ADC code")
> > > Signed-off-by: Vincent Stehlé <vincent.stehle@...oste.net>
> > > Cc: Dan Murphy <dmurphy@...com>
> > > Cc: Jonathan Cameron <Jonathan.Cameron@...wei.com>
> > > ---
> > >  drivers/iio/adc/ti-ads124s08.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/iio/adc/ti-ads124s08.c b/drivers/iio/adc/ti-ads124s08.c
> > > index 53f17e4f2f230..552c2be8d87ad 100644
> > > --- a/drivers/iio/adc/ti-ads124s08.c
> > > +++ b/drivers/iio/adc/ti-ads124s08.c
> > > @@ -202,7 +202,7 @@ static int ads124s_read(struct iio_dev *indio_dev, unsigned int chan)
> > >  	};
> > >  
> > >  	priv->data[0] = ADS124S08_CMD_RDATA;
> > > -	memset(&priv->data[1], ADS124S08_CMD_NOP, sizeof(priv->data));
> > > +	memset(&priv->data[1], ADS124S08_CMD_NOP, sizeof(priv->data) - 1);
> > >  
> > >  	ret = spi_sync_transfer(priv->spi, t, ARRAY_SIZE(t));
> > >  	if (ret < 0)
> > >     
> > 
> > Reviewed-by: Dan Murphy <dmurphy@...com>  
> 
> Applied to the fixes-togreg branch of iio.git and pushed out as testing
> for the autobuilders to play with it.
Wrong finger memory. Not pushed out as testing. Pushed out as fixes-togreg!

Jonathan
> 
> Thanks,
> 
> Jonathan