linux-kernel - Re: [PATCH v10 01/18] counter: Introduce the Generic Counter interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190408215515.GA27592@amd>
Date:   Mon, 8 Apr 2019 23:55:15 +0200
From:   Pavel Machek <pavel@....cz>
To:     William Breathitt Gray <vilhelm.gray@...il.com>
Cc:     gregkh@...uxfoundation.org, jic23@...nel.org,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org,
        fabrice.gasnier@...com, benjamin.gaignard@...com, knaack.h@....de,
        lars@...afoo.de, pmeerw@...erw.net, akpm@...ux-foundation.org,
        david@...hnology.com, robh+dt@...nel.org, mark.rutland@....com,
        shawnguo@...nel.org, leoyang.li@....com, daniel.lezcano@...aro.org,
        tglx@...utronix.de, thierry.reding@...il.com, esben@...bendal.dk,
        linux-pwm@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        patrick.havelange@...ensium.com,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>
Subject: Re: [PATCH v10 01/18] counter: Introduce the Generic Counter
 interface

Hi!

> +const char *const counter_count_direction_str[2] = {
> +	[COUNTER_COUNT_DIRECTION_FORWARD] = "forward",
> +	[COUNTER_COUNT_DIRECTION_BACKWARD] = "backward"
> +};
> +EXPORT_SYMBOL_GPL(counter_count_direction_str);
> +
> +const char *const counter_count_mode_str[4] = {
> +	[COUNTER_COUNT_MODE_NORMAL] = "normal",
> +	[COUNTER_COUNT_MODE_RANGE_LIMIT] = "range limit",
> +	[COUNTER_COUNT_MODE_NON_RECYCLE] = "non-recycle",
> +	[COUNTER_COUNT_MODE_MODULO_N] = "modulo-n"
> +};
> +EXPORT_SYMBOL_GPL(counter_count_mode_str);

Dunno. Exporting const tables saying "forward" and "backward". Can we
... somehow make it work without need to export this?

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)