linux-kernel - Re: [PATCH v2 1/3] ASoC: rt5677: allow multiple interrupt sources

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190408061014.GG2803@sirena.org.uk>
Date:   Mon, 8 Apr 2019 13:10:14 +0700
From:   Mark Brown <broonie@...nel.org>
To:     Fletcher Woodruff <fletcherw@...omium.org>
Cc:     linux-kernel@...r.kernel.org, Ben Zhang <benzh@...omium.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Liam Girdwood <lgirdwood@...il.com>,
        Oder Chiou <oder_chiou@...ltek.com>,
        Takashi Iwai <tiwai@...e.com>,
        Curtis Malainey <cujomalainey@...omium.org>,
        Ross Zwisler <zwisler@...gle.com>, alsa-devel@...a-project.org
Subject: Re: [PATCH v2 1/3] ASoC: rt5677: allow multiple interrupt sources

On Fri, Apr 05, 2019 at 02:42:55PM -0600, Fletcher Woodruff wrote:

> This patch allows headphone plug detect and mic present
> detect to be enabled at the same time. This patch implements
> an irq_chip with irq_domain directly instead of using
> regmap_irq, so that interrupt source line polarities can
> be flipped to support irq sharing.

This changelog still doesn't explain why there is a need to open code
this rather than having the irq_chip and irq_domain provided by
regmap-irq support whatever is missing here.  You said it "needs its own
irq regardless for hotword detection" but provided no information on why
this is.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)