linux-kernel - Re: [PATCH] staging: iio: cdc: ad7746: Replace bitshift by BIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55d0cb7ecb968e4a2cc82fda5950b237ffbb435c.camel@perches.com>
Date:   Mon, 08 Apr 2019 05:34:44 -0700
From:   Joe Perches <joe@...ches.com>
To:     Lucas Oshiro <lucasseikioshiro@...il.com>, lars@...afoo.de,
        Michael.Hennerich@...log.com, stefan.popa@...log.com,
        jic23@...nel.org, knaack.h@....de, pmeerw@...erw.net,
        gregkh@...uxfoundation.org
Cc:     linux-iio@...r.kernel.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, kernel-usp@...glegroups.com
Subject: Re: [PATCH] staging: iio: cdc: ad7746: Replace bitshift by BIT

On Wed, 2019-04-03 at 17:45 -0300, Lucas Oshiro wrote:
> Replace bitshifts on lines 54, 56 and 78 of ad7746.c.

checkpatch is not something that should be followed
blindly.  Look at the shifted blocks and determine if
you think it was better before your proposed change.

> diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/staging/iio/cdc/ad7746.c
[]
> @@ -51,9 +51,9 @@
>  #define AD7746_CAPSETUP_CACHOP		BIT(0)
>  
>  /* Voltage/Temperature Setup Register Bit Designations (AD7746_REG_VT_SETUP) */
> -#define AD7746_VTSETUP_VTEN		(1 << 7)
> +#define AD7746_VTSETUP_VTEN		BIT(7)
>  #define AD7746_VTSETUP_VTMD_INT_TEMP	(0 << 5)
> -#define AD7746_VTSETUP_VTMD_EXT_TEMP	(1 << 5)
> +#define AD7746_VTSETUP_VTMD_EXT_TEMP	BIT(5)
>  #define AD7746_VTSETUP_VTMD_VDD_MON	(2 << 5)
>  #define AD7746_VTSETUP_VTMD_EXT_VIN	(3 << 5)
>  #define AD7746_VTSETUP_EXTREF		BIT(4)
> @@ -75,7 +75,7 @@
>  #define AD7746_CONF_VTFS_MASK		GENMASK(7, 6)
>  #define AD7746_CONF_CAPFS_MASK		GENMASK(5, 3)
>  #define AD7746_CONF_MODE_IDLE		(0 << 0)
> -#define AD7746_CONF_MODE_CONT_CONV	(1 << 0)
> +#define AD7746_CONF_MODE_CONT_CONV	BIT(0)
>  #define AD7746_CONF_MODE_SINGLE_CONV	(2 << 0)
>  #define AD7746_CONF_MODE_PWRDN		(3 << 0)
>  #define AD7746_CONF_MODE_OFFS_CAL	(5 << 0)

Now the code looks unbalanced.