linux-kernel - Re: [PATCH net v3] net: vrf: Fix ping failed when vrf mtu is set to 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <22ff0d05-c1af-ad08-4cae-39dec91eff47@cumulusnetworks.com>
Date:   Sun, 7 Apr 2019 20:51:05 -0700
From:   David Ahern <dsa@...ulusnetworks.com>
To:     linmiaohe <linmiaohe@...wei.com>, shrijeet@...il.com,
        davem@...emloft.net, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Mingfangsen <mingfangsen@...wei.com>
Subject: Re: [PATCH net v3] net: vrf: Fix ping failed when vrf mtu is set to 0

On 4/7/19 7:04 PM, linmiaohe wrote:
> From: Miaohe Lin <linmiaohe@...wei.com>
> 
> When the mtu of a vrf device is set to 0, it would cause ping
> failed. So I think we should limit vrf mtu in a reasonable range
> to solve this problem. I set dev->min_mtu to IPV6_MIN_MTU, so it
> will works for both ipv4 and ipv6. And if dev->max_mtu still be 0
> can be confusing, so I set dev->max_mtu to ETH_MAX_MTU.
> 
> Here is the reproduce step:
> 
> 1.Config vrf interface and set mtu to 0:
> 3: enp4s0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc fq_codel
> master vrf1 state UP mode DEFAULT group default qlen 1000
>     link/ether 52:54:00:9e:dd:c1 brd ff:ff:ff:ff:ff:ff
> 
> 2.Ping peer:
> 3: enp4s0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc fq_codel
> master vrf1 state UP group default qlen 1000
>     link/ether 52:54:00:9e:dd:c1 brd ff:ff:ff:ff:ff:ff
>     inet 10.0.0.1/16 scope global enp4s0
>        valid_lft forever preferred_lft forever
> connect: Network is unreachable
> 
> 3.Set mtu to default value, ping works:
> PING 10.0.0.2 (10.0.0.2) 56(84) bytes of data.
> 64 bytes from 10.0.0.2: icmp_seq=1 ttl=64 time=1.88 ms
> 
> Fixes: ad49bc6361ca2 ("net: vrf: remove MTU limits for vrf device")
> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>
> ---

Reviewed-by: David Ahern <dsahern@...il.com>