linux-kernel - Re: CBL issue #431: lld: x86_64: sysfs: cannot create duplicate filename $module/.rodata.cst{16,32}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <99dde862-6aee-65a0-8b39-33b8ac10df45@redhat.com>
Date:   Mon, 8 Apr 2019 15:58:29 +0200
From:   Denys Vlasenko <dvlasenk@...hat.com>
To:     sedat.dilek@...il.com
Cc:     linux-kernel@...r.kernel.org, x86@...nel.org
Subject: Re: CBL issue #431: lld: x86_64: sysfs: cannot create duplicate
 filename $module/.rodata.cst{16,32}

On 4/8/19 3:56 PM, Denys Vlasenko wrote:
> I propose to change section name, append _module_ name and optionally
> a comment why this is done:
> 
>   /* NB: section is mergeable, all elements must be aligned 16-byte blocks */
> +/* There is more than one object in this section, let's use module name
> +   as unique suffix */

Probably not clear enough... maybe this is better:

+/* There is more than one object in this section, let's use module name
+   instead of object name as unique suffix */
-.section        .rodata.cst16, "aM", @progbits, 16

and do not use '-' in the name, replace with '_':

+.section        .rodata.cst16.cast6_avx_x86_64_asm_64, "aM", @progbits, 16