linux-kernel - Re: CBL issue #431: lld: x86_64: sysfs: cannot create duplicate filename $module/.rodata.cst{16,32}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 8 Apr 2019 17:04:37 +0200
From:   Denys Vlasenko <dvlasenk@...hat.com>
To:     sedat.dilek@...il.com
Cc:     linux-kernel@...r.kernel.org, x86@...nel.org
Subject: Re: CBL issue #431: lld: x86_64: sysfs: cannot create duplicate
 filename $module/.rodata.cst{16,32}

On 4/8/19 4:57 PM, Sedat Dilek wrote:
> We have arch/x86/crypto/chacha-avx2-x86_64.S and
> arch/x86/crypto/chacha-avx512vl-x86_64.S:
> 
> .rodata.cst32.CTR2BL
> .rodata.cst32.CTR4BL
> .rodata.cst32.CTR2BL
> .rodata.cst32.CTR4BL
> 
> ...and in arch/x86/crypto/sha256-avx2-asm.S and
> arch/x86/crypto/sha512-avx2-asm.S:
> 
> .rodata.cst32.PSHUFFLE_BYTE_FLIP_MASK
> 
> Correct?

You mean, we have duplicate section names.

Well, this brings me to my initial response -
"Not sure how exactly this causes the error".

Duplicate section names are allowed by the linker.
There is nothing wrong with that.

The warnings you see come from some other tooling,
which does not handle correctly object files with more
than one section with the same name.

(Having unique names is still preferable,
it helps humans to more easily find where sections come from,
and for potential future --gc-sections optimization).