linux-kernel - Re: [PATCH 2/6] MIPS: SGI-IP27: remove setup of RTC platform device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 8 Apr 2019 20:48:47 +0200
From:   Thomas Bogendoerfer <tbogendoerfer@...e.de>
To:     David Miller <davem@...emloft.net>
Cc:     ralf@...ux-mips.org, paul.burton@...s.com, jhogan@...nel.org,
        dmitry.torokhov@...il.com, lee.jones@...aro.org,
        a.zummo@...ertech.it, alexandre.belloni@...tlin.com,
        gregkh@...uxfoundation.org, jslaby@...e.com,
        linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-input@...r.kernel.org, netdev@...r.kernel.org,
        linux-rtc@...r.kernel.org, linux-serial@...r.kernel.org
Subject: Re: [PATCH 2/6] MIPS: SGI-IP27: remove setup of RTC platform device

On Mon, 08 Apr 2019 10:05:28 -0700 (PDT)
David Miller <davem@...emloft.net> wrote:

> From: Thomas Bogendoerfer <tbogendoerfer@...e.de>
> Date: Mon,  8 Apr 2019 16:20:54 +0200
> 
> > RTC platform device will be setup by new IOC3 MFD driver, therefore
> > remove it from IP27 platform code.
> > 
> > Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@...e.de>
> 
> You cannot break the driver like this.
> 
> Your patch series must be fully bisectable, which means that after
> this patch is applied things still must continue working properly.

I see your point and the ethernet driver itself will work properly, but of
course IP27 will be working again after applying the whole series. One
way I can see to solve this to also add the addition of the serial driver
into it. Then we are on par with the current driver. Does this solve your
concern ?

Thomas.

-- 
SUSE Linux GmbH
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)