lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAPpJ_edx2J6RyH2MuysXhE4hM61mWn+Th83HNeQtsFLF1K_mzA@mail.gmail.com> Date: Mon, 8 Apr 2019 14:02:14 +0800 From: Jian-Hong Pan <jian-hong@...lessm.com> To: Thomas Gleixner <tglx@...utronix.de> Cc: Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>, x86@...nel.org, Linux Kernel <linux-kernel@...r.kernel.org>, Linux Upstreaming Team <linux@...lessm.com>, Daniel Drake <drake@...lessm.com> Subject: Re: [PATCH] x86/reboot: Use efi reboot for Acer TravelMate X514-51T Thomas Gleixner <tglx@...utronix.de> 於 2019年4月6日 週六 上午5:14寫道: > > On Mon, 1 Apr 2019, Jian-Hong Pan wrote: > > +/* > > + * Some machines require the "reboot=e" commandline options > > + */ > > +static int __init set_efi_reboot(const struct dmi_system_id *d) > > +{ > > + if (reboot_type != BOOT_EFI) { > > + reboot_type = BOOT_EFI; > > So if EFI is disabled in the kernel this will fall through to BOOT_BIOS. Is > that intended behaviour? If not choose EFI as the reboot type, system will use APCI reboot type on Acer TravelMate X514-51T. If the reboot type is set as BIOS by appending "reboot=b", system cannot reboot and hangs up when shutdown. > > + pr_info("%s series board detected. Selecting %s-method for reboot.\n", > > + d->ident, "EFI"); > > Is thee a reason not to write "EFI" in the string itself? Just simply follow the format like functions: set_acpi_reboot, set_bios_reboot https://elixir.bootlin.com/linux/v5.1-rc4/source/arch/x86/kernel/reboot.c#L60 BR, Jian-Hong Pan
Powered by blists - more mailing lists