lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 8 Apr 2019 21:10:00 +0000
From:   <Adham.Abozaeid@...rochip.com>
To:     <hofrat@...dl.org>
CC:     <Ajay.Kathat@...rochip.com>, <gregkh@...uxfoundation.org>,
        <linux-wireless@...r.kernel.org>, <devel@...verdev.osuosl.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RFC] staging: wilc1000: give usleep_range a range

Hi Nicholas

On 4/6/19 5:01 AM, Nicholas Mc Guire wrote:
> External E-Mail
>
>
> Someone that knows the motivation for setting the time to 2 millisecond
> might need to check if the 2 milliseconds where seen as tollerable max or
> min - I'm assuming it was the min so extending.

2 msec is the time the chip takes to wake up from sleep.

Increasing the maximum to 5 msec will impact the throughput since this call is on the transmit path.

> diff --git a/drivers/staging/wilc1000/wilc_wlan.c b/drivers/staging/wilc1000/wilc_wlan.c
> index c238969..42da533 100644
> --- a/drivers/staging/wilc1000/wilc_wlan.c
> +++ b/drivers/staging/wilc1000/wilc_wlan.c
> @@ -408,7 +408,7 @@ void chip_wakeup(struct wilc *wilc)
>  			wilc->hif_func->hif_write_reg(wilc, 1, reg & ~BIT(1));
>  
>  			do {
> -				usleep_range(2 * 1000, 2 * 1000);
> +				usleep_range(2 * 1000, 5 * 1000);
>  				wilc_get_chipid(wilc, true);
>  			} while (wilc_get_chipid(wilc, true) == 0);
>  		} while (wilc_get_chipid(wilc, true) == 0);
> @@ -423,7 +423,7 @@ void chip_wakeup(struct wilc *wilc)
>  						     &clk_status_reg);
>  
>  			while ((clk_status_reg & 0x1) == 0) {
> -				usleep_range(2 * 1000, 2 * 1000);
> +				usleep_range(2 * 1000, 5 * 1000);
>  
>  				wilc->hif_func->hif_read_reg(wilc, 0xf1,
>  							     &clk_status_reg);


Thanks,

Adham

Powered by blists - more mailing lists