linux-kernel - Re: [PATCH] fat: issue flush after the writeback of FAT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87a7gzbvmw.fsf@mail.parknet.co.jp>
Date:   Tue, 09 Apr 2019 14:22:31 +0900
From:   OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To:     "Darrick J. Wong" <darrick.wong@...cle.com>
Cc:     Hou Tao <houtao1@...wei.com>, linux-fsdevel@...r.kernel.org,
        viro@...iv.linux.org.uk, jack@...e.cz, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fat: issue flush after the writeback of FAT

"Darrick J. Wong" <darrick.wong@...cle.com> writes:

>> +	err = __generic_file_fsync(filp, start, end, datasync);
>> +	if (err)
>> +		return err;
>>  
>> -	res = generic_file_fsync(filp, start, end, datasync);
>>  	err = sync_mapping_buffers(MSDOS_SB(inode->i_sb)->fat_inode->i_mapping);
>
> Huh.  I would've thought that flushing the FAT would also be required
> at the end of a WB_SYNC_ALL (aka data integrity) writepages call?

In fatfs implement, FAT area is flushed by sync_mapping_buffers(fat_inode). 
(FAT buffer is dirtied only by using bh->b_assoc_map to fat_inode)

Thanks.
-- 
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>