linux-kernel - [PATCH] net:bridge:bridge mtu auto tuning does not always work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue,  9 Apr 2019 07:36:42 +0000
From:   Huang Rui <huangruippp@...il.com>
To:     davem@...emloft.net
Cc:     ast@...nel.org, daniel@...earbox.net, jakub.kicinski@...ronome.com,
        hawk@...nel.org, john.fastabend@...il.com, kafai@...com,
        songliubraving@...com, yhs@...com, jiri@...lanox.com,
        ecree@...arflare.com, idosch@...lanox.com, petrm@...lanox.com,
        alexander.h.duyck@...el.com, amritha.nambiar@...el.com,
        lirongqing@...du.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, xdp-newbies@...r.kernel.org,
        bpf@...r.kernel.org, huangruiPPP@...il.com
Subject: [PATCH] net:bridge:bridge mtu auto tuning does not always work

If someone setup a bridge and add a port(for example: eth0)
into the bridge, but configure the bridge's mtu which is equal
to eth0's mtu, the auto tuning flag will not be set true. But
the meaning of the auto tuning flag is that it will be set true
if a user configure bridge's mtu.

Signed-off-by: Huang Rui <huangruiPPP@...il.com>
---
 net/core/dev.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/net/core/dev.c b/net/core/dev.c
index 2b67f2a..ba410d7 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -7670,8 +7670,12 @@ int dev_set_mtu_ext(struct net_device *dev, int new_mtu,
 {
 	int err, orig_mtu;
 
-	if (new_mtu == dev->mtu)
-		return 0;
+	if (new_mtu == dev->mtu) {
+		if (dev->priv_flags & IFF_EBRIDGE)
+			return __dev_set_mtu(dev, new_mtu);
+		else
+			return 0;
+	}
 
 	/* MTU must be positive, and in range */
 	if (new_mtu < 0 || new_mtu < dev->min_mtu) {
-- 
1.8.3.1