lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <2695.1554802492@warthog.procyon.org.uk> Date: Tue, 09 Apr 2019 10:34:52 +0100 From: David Howells <dhowells@...hat.com> To: "Gustavo A. R. Silva" <gustavo@...eddedor.com> Cc: dhowells@...hat.com, linux-afs@...ts.infradead.org, linux-kernel@...r.kernel.org, Kees Cook <keescook@...gle.com>, Stephen Rothwell <sfr@...b.auug.org.au> Subject: Re: [PATCH] afs: Mark expected switch fall-throughs Gustavo A. R. Silva <gustavo@...eddedor.com> wrote: Please fix the compiler so that you can annotate a switch-statement to say that every case must fall through (except, perhaps, the last). > /* extract the FID array and its count in two steps */ > + /* fall through */ > case 1: Capitialise "Fall" for consistency, please, and can you put the fall-through marker *before* the comment introducing the case please? It belongs to the preceding section. > /* extract the callback array and its count in two steps */ > + /* fall through */ > case 3: Ditto. > /* extract the FID array and its count in two steps */ > + /* Fall through */ Ditto on putting the fall-through before the introductory comment. (And more dittos). > - /* Extract fsEndpoints[] entries */ > + /* Fall through - and extract fsEndpoints[] entries */ And here you're doing something different yet again, though you could drop either the "-" or the "and". David
Powered by blists - more mailing lists