linux-kernel - Re: [Xen-devel][PATCH] xen/cameraif: add ABI for para-virtual camera

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e9b3a843-1b1f-94c2-e123-09fb26d89753@gmail.com>
Date:   Tue, 9 Apr 2019 16:26:42 +0300
From:   Oleksandr Andrushchenko <andr2000@...il.com>
To:     Juergen Gross <jgross@...e.com>, xen-devel@...ts.xenproject.org,
        linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
        konrad.wilk@...cle.com, hverkuil@...all.nl,
        boris.ostrovsky@...cle.com
Cc:     Oleksandr Andrushchenko <oleksandr_andrushchenko@...m.com>
Subject: Re: [Xen-devel][PATCH] xen/cameraif: add ABI for para-virtual camera

On 4/9/19 12:46 PM, Juergen Gross wrote:
> On 09/04/2019 11:33, Oleksandr Andrushchenko wrote:
>> On 4/9/19 12:28 PM, Juergen Gross wrote:
>>> On 09/04/2019 11:15, Oleksandr Andrushchenko wrote:
>>>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@...m.com>
>>>>
>>>> This is the ABI for the two halves of a para-virtualized
>>>> camera driver which extends Xen's reach multimedia capabilities even
>>>> further enabling it for video conferencing, In-Vehicle Infotainment,
>>>> high definition maps etc.
>>>>
>>>> The initial goal is to support most needed functionality with the
>>>> final idea to make it possible to extend the protocol if need be:
>>>>
>>>> 1. Provide means for base virtual device configuration:
>>>>    - pixel formats
>>>>    - resolutions
>>>>    - frame rates
>>>> 2. Support basic camera controls:
>>>>    - contrast
>>>>    - brightness
>>>>    - hue
>>>>    - saturation
>>>> 3. Support streaming control
>>>>
>>>> Signed-off-by: Oleksandr Andrushchenko
>>>> <oleksandr_andrushchenko@...m.com>
>>>> Cc: Juergen Gross <jgross@...e.com>
>>>> Cc: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
>>>> Cc: Hans Verkuil <hverkuil@...all.nl>
>>> I'm in principle fine with this patch, but it should be sent as part of
>>> a series using that header. In case the related driver isn't accepted
>>> we'd end up with a stale header file.
>> Hm, I am doing this as I did for the rest of protocols before:
>> 1. Get the protocol in Xen
>> 2. Get the copy in Linux
>> 3. Upstream driver (use header)
> Sorry for not having done the review properly in the past. ;-)
>
>> Even if the driver is not accepted (hope this won't happen)
>> then this patch makes Xen and Linux properly aligned anyway.
>> Which is IMO good
> Having an unused header file is not good.
>
> Be assured I'm going to give you the needed Reviewed-by: tag for
> the patch adding the header in a series using it.
Ok, sounds good
>
>
> Juergen