| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20190409142126.GC4190@redhat.com>
Date: Tue, 9 Apr 2019 10:21:26 -0400
From: Jerome Glisse <jglisse@...hat.com>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: linux-kernel@...r.kernel.org, linux-mm@...ck.org,
Christian König <christian.koenig@....com>,
Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>,
Jani Nikula <jani.nikula@...ux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@...el.com>, Jan Kara <jack@...e.cz>,
Andrea Arcangeli <aarcange@...hat.com>,
Peter Xu <peterx@...hat.com>,
Felix Kuehling <Felix.Kuehling@....com>,
Jason Gunthorpe <jgg@...lanox.com>,
Ross Zwisler <zwisler@...nel.org>,
Dan Williams <dan.j.williams@...el.com>,
Paolo Bonzini <pbonzini@...hat.com>,
Alex Deucher <alexander.deucher@....com>,
Radim Krčmář <rkrcmar@...hat.com>,
Michal Hocko <mhocko@...nel.org>,
Ben Skeggs <bskeggs@...hat.com>,
Ralph Campbell <rcampbell@...dia.com>,
John Hubbard <jhubbard@...dia.com>, kvm@...r.kernel.org,
dri-devel@...ts.freedesktop.org, linux-rdma@...r.kernel.org,
Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH v6 0/8] mmu notifier provide context informations
Andrew anything blocking this for 5.2 ? Should i ask people (ie the end
user of this) to re-ack v6 (it is the same as previous version just rebase
and dropped kvm bits).
On Tue, Mar 26, 2019 at 12:47:39PM -0400, jglisse@...hat.com wrote:
> From: Jérôme Glisse <jglisse@...hat.com>
>
> (Andrew this apply on top of my HMM patchset as otherwise you will have
> conflict with changes to mm/hmm.c)
>
> Changes since v5:
> - drop KVM bits waiting for KVM people to express interest if they
> do not then i will post patchset to remove change_pte_notify as
> without the changes in v5 change_pte_notify is just useless (it
> it is useless today upstream it is just wasting cpu cycles)
> - rebase on top of lastest Linus tree
>
> Previous cover letter with minor update:
>
>
> Here i am not posting users of this, they already have been posted to
> appropriate mailing list [6] and will be merge through the appropriate
> tree once this patchset is upstream.
>
> Note that this serie does not change any behavior for any existing
> code. It just pass down more information to mmu notifier listener.
>
> The rational for this patchset:
>
> CPU page table update can happens for many reasons, not only as a
> result of a syscall (munmap(), mprotect(), mremap(), madvise(), ...)
> but also as a result of kernel activities (memory compression, reclaim,
> migration, ...).
>
> This patch introduce a set of enums that can be associated with each
> of the events triggering a mmu notifier:
>
> - UNMAP: munmap() or mremap()
> - CLEAR: page table is cleared (migration, compaction, reclaim, ...)
> - PROTECTION_VMA: change in access protections for the range
> - PROTECTION_PAGE: change in access protections for page in the range
> - SOFT_DIRTY: soft dirtyness tracking
>
> Being able to identify munmap() and mremap() from other reasons why the
> page table is cleared is important to allow user of mmu notifier to
> update their own internal tracking structure accordingly (on munmap or
> mremap it is not longer needed to track range of virtual address as it
> becomes invalid). Without this serie, driver are force to assume that
> every notification is an munmap which triggers useless trashing within
> drivers that associate structure with range of virtual address. Each
> driver is force to free up its tracking structure and then restore it
> on next device page fault. With this serie we can also optimize device
> page table update [6].
>
> More over this can also be use to optimize out some page table updates
> like for KVM where we can update the secondary MMU directly from the
> callback instead of clearing it.
>
> ACKS AMD/RADEON https://lkml.org/lkml/2019/2/1/395
> ACKS RDMA https://lkml.org/lkml/2018/12/6/1473
>
> Cheers,
> Jérôme
>
> [1] v1 https://lkml.org/lkml/2018/3/23/1049
> [2] v2 https://lkml.org/lkml/2018/12/5/10
> [3] v3 https://lkml.org/lkml/2018/12/13/620
> [4] v4 https://lkml.org/lkml/2019/1/23/838
> [5] v5 https://lkml.org/lkml/2019/2/19/752
> [6] patches to use this:
> https://lkml.org/lkml/2019/1/23/833
> https://lkml.org/lkml/2019/1/23/834
> https://lkml.org/lkml/2019/1/23/832
> https://lkml.org/lkml/2019/1/23/831
>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: linux-mm@...ck.org
> Cc: Christian König <christian.koenig@....com>
> Cc: Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>
> Cc: Jani Nikula <jani.nikula@...ux.intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@...el.com>
> Cc: Jan Kara <jack@...e.cz>
> Cc: Andrea Arcangeli <aarcange@...hat.com>
> Cc: Peter Xu <peterx@...hat.com>
> Cc: Felix Kuehling <Felix.Kuehling@....com>
> Cc: Jason Gunthorpe <jgg@...lanox.com>
> Cc: Ross Zwisler <zwisler@...nel.org>
> Cc: Dan Williams <dan.j.williams@...el.com>
> Cc: Paolo Bonzini <pbonzini@...hat.com>
> Cc: Alex Deucher <alexander.deucher@....com>
> Cc: Radim Krčmář <rkrcmar@...hat.com>
> Cc: Michal Hocko <mhocko@...nel.org>
> Cc: Christian Koenig <christian.koenig@....com>
> Cc: Ben Skeggs <bskeggs@...hat.com>
> Cc: Ralph Campbell <rcampbell@...dia.com>
> Cc: John Hubbard <jhubbard@...dia.com>
> Cc: kvm@...r.kernel.org
> Cc: dri-devel@...ts.freedesktop.org
> Cc: linux-rdma@...r.kernel.org
> Cc: Arnd Bergmann <arnd@...db.de>
>
> Jérôme Glisse (8):
> mm/mmu_notifier: helper to test if a range invalidation is blockable
> mm/mmu_notifier: convert user range->blockable to helper function
> mm/mmu_notifier: convert mmu_notifier_range->blockable to a flags
> mm/mmu_notifier: contextual information for event enums
> mm/mmu_notifier: contextual information for event triggering
> invalidation v2
> mm/mmu_notifier: use correct mmu_notifier events for each invalidation
> mm/mmu_notifier: pass down vma and reasons why mmu notifier is
> happening v2
> mm/mmu_notifier: mmu_notifier_range_update_to_read_only() helper
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c | 8 ++--
> drivers/gpu/drm/i915/i915_gem_userptr.c | 2 +-
> drivers/gpu/drm/radeon/radeon_mn.c | 4 +-
> drivers/infiniband/core/umem_odp.c | 5 +-
> drivers/xen/gntdev.c | 6 +--
> fs/proc/task_mmu.c | 3 +-
> include/linux/mmu_notifier.h | 63 +++++++++++++++++++++++--
> kernel/events/uprobes.c | 3 +-
> mm/hmm.c | 6 +--
> mm/huge_memory.c | 14 +++---
> mm/hugetlb.c | 12 +++--
> mm/khugepaged.c | 3 +-
> mm/ksm.c | 6 ++-
> mm/madvise.c | 3 +-
> mm/memory.c | 25 ++++++----
> mm/migrate.c | 5 +-
> mm/mmu_notifier.c | 12 ++++-
> mm/mprotect.c | 4 +-
> mm/mremap.c | 3 +-
> mm/oom_kill.c | 3 +-
> mm/rmap.c | 6 ++-
> virt/kvm/kvm_main.c | 3 +-
> 22 files changed, 147 insertions(+), 52 deletions(-)
>
> --
> 2.20.1
>
Powered by blists - more mailing lists