linux-kernel - Re: [PATCH] perf stat: Disable DIR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190409150109.GB31835@kernel.org>
Date:   Tue, 9 Apr 2019 12:01:09 -0300
From:   Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
To:     Jiri Olsa <jolsa@...nel.org>
Cc:     lkml <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [PATCH] perf stat: Disable DIR_FORMAT feature for record

Em Tue, Apr 09, 2019 at 12:01:56PM +0200, Jiri Olsa escreveu:
> Arnaldo reported assertion in perf stat record:
> 
>   assertion failed at util/header.c:875

Thanks, applied and added:

    Fixes: 258031c017c3 ("perf header: Add DIR_FORMAT feature to describe directory data")

- Arnaldo
> 
> There's no support for this in perf state record
> command, disabling the feature.
> 
> Reported-by: Arnaldo Carvalho de Melo <acme@...hat.com>
> Link: http://lkml.kernel.org/n/tip-2uhyh815jfwikg5uhve8log6@git.kernel.org
> Signed-off-by: Jiri Olsa <jolsa@...nel.org>
> ---
>  tools/perf/builtin-stat.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
> index 7f9c4b7f5d69..a3c060878faa 100644
> --- a/tools/perf/builtin-stat.c
> +++ b/tools/perf/builtin-stat.c
> @@ -1322,6 +1322,7 @@ static void init_features(struct perf_session *session)
>  	for (feat = HEADER_FIRST_FEATURE; feat < HEADER_LAST_FEATURE; feat++)
>  		perf_header__set_feat(&session->header, feat);
>  
> +	perf_header__clear_feat(&session->header, HEADER_DIR_FORMAT);
>  	perf_header__clear_feat(&session->header, HEADER_BUILD_ID);
>  	perf_header__clear_feat(&session->header, HEADER_TRACING_DATA);
>  	perf_header__clear_feat(&session->header, HEADER_BRANCH_STACK);
> -- 
> 2.17.2

-- 

- Arnaldo