linux-kernel - [PATCH] scsi: megaraid_sas: Reporting evt_detail->code in megasas_decode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20190409152338.27874-1-e.velu@criteo.com>
Date:   Tue,  9 Apr 2019 17:23:38 +0200
From:   Erwan Velu <erwanaliasr1@...il.com>
To:     unlisted-recipients:; (no To-header on input)
Cc:     Erwan Velu <e.velu@...teo.com>,
        Kashyap Desai <kashyap.desai@...adcom.com>,
        Sumit Saxena <sumit.saxena@...adcom.com>,
        Shivasharan S <shivasharan.srikanteshwara@...adcom.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        megaraidlinux.pdl@...adcom.com (open list:MEGARAID SCSI/SAS DRIVERS),
        linux-scsi@...r.kernel.org (open list:MEGARAID SCSI/SAS DRIVERS),
        linux-kernel@...r.kernel.org (open list)
Subject: [PATCH] scsi: megaraid_sas: Reporting evt_detail->code in megasas_decode_evt

When printing a megasas_decode_evt() message, the code member of the evt_detail is not reported.
This make the debugging more complicated as some code paths depends on this value.

Reporting the code member makes the context more explicit.

Signed-off-by: Erwan Velu <e.velu@...teo.com>
---
 drivers/scsi/megaraid/megaraid_sas_base.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
index 293f5cf524d7..222166c659bb 100644
--- a/drivers/scsi/megaraid/megaraid_sas_base.c
+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
@@ -392,8 +392,9 @@ megasas_decode_evt(struct megasas_instance *instance)
 	class_locale.word = le32_to_cpu(evt_detail->cl.word);
 
 	if (class_locale.members.class >= MFI_EVT_CLASS_CRITICAL)
-		dev_info(&instance->pdev->dev, "%d (%s/0x%04x/%s) - %s\n",
+		dev_info(&instance->pdev->dev, "%d code:%d (%s/0x%04x/%s) - %s\n",
 			le32_to_cpu(evt_detail->seq_num),
+			le32_to_cpu(instance->evt_detail->code),
 			format_timestamp(le32_to_cpu(evt_detail->time_stamp)),
 			(class_locale.members.locale),
 			format_class(class_locale.members.class),
-- 
2.21.0