linux-kernel - Re: [PATCH] pinctrl: pinctrl-intel: move gpio suspend/resume to noirq phase

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 9 Apr 2019 18:28:46 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Mika Westerberg <mika.westerberg@...ux.intel.com>
Cc:     Binbin Wu <binbin.wu@...el.com>, linux-kernel@...r.kernel.org,
        linux-gpio@...r.kernel.org
Subject: Re: [PATCH] pinctrl: pinctrl-intel: move gpio suspend/resume to
 noirq phase

On Mon, Apr 08, 2019 at 03:51:26PM +0300, Mika Westerberg wrote:
> On Mon, Apr 08, 2019 at 03:43:48PM +0300, Andy Shevchenko wrote:
> > On Mon, Apr 08, 2019 at 06:49:26PM +0800, Binbin Wu wrote:
> > > In current driver, SET_LATE_SYSTEM_SLEEP_PM_OPS is used to install the
> > > callbacks for suspend/resume.
> > > GPIO pin may be used as the interrupt pin by some device. However, using
> > > SET_LATE_SYSTEM_SLEEP_PM_OPS() to install the callbacks, the resume
> > > callback is called after resume_device_irqs(). Unintended interrupts may
> > > arrive due to resuming device irqs first, but the GPIO controller is not
> > > properly restored.
> > > 
> > > Normally, for a SMP system, there are multiple cores, so even when there are
> > > unintended interrupts, BSP gets the chance to init the gpio chip soon.
> > 
> > gpio -> GPIO.
> > (If Mika is okay with patch content, I may fix this when applying)
> 
> Yup, this looks good to me.
> 
> Acked-by: Mika Westerberg <mika.westerberg@...ux.intel.com>

Pushed to my review and testing queue, thanks!

-- 
With Best Regards,
Andy Shevchenko