linux-kernel - RE: Issues with i.MX SPI DMA transfers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <VI1PR04MB454302BAF353124ED13747DC892D0@VI1PR04MB4543.eurprd04.prod.outlook.com>
Date:   Tue, 9 Apr 2019 03:26:15 +0000
From:   Robin Gong <yibin.gong@....com>
To:     Igor Plyatov <plyatov@...il.com>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-spi@...r.kernel.org" <linux-spi@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>,
        Fabio Estevam <festevam@...il.com>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Shawn Guo <shawnguo@...nel.org>,
        Mark Brown <broonie@...nel.org>,
        "dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>,
        Vinod Koul <vkoul@...nel.org>,
        Dan Williams <dan.j.williams@...el.com>,
        Andy Duan <fugang.duan@....com>, Han Xu <han.xu@....com>,
        Clark Wang <xiaoning.wang@....com>
Subject: RE: Issues with i.MX SPI DMA transfers

Hi Igor,
	Please have a try with the attached patches, and revert 25aaa75df1e6, ad0d92d7ba6a
, dd4b487b32a3, df07101e1c4a before apply. Besides XCH, tx thresh should be set to 0 ,
now no failure caught on ecspi5.

> -----Original Message-----
> From: Robin Gong
> Sent: 2019年4月2日 16:33
> To: 'Igor Plyatov' <plyatov@...il.com>; Uwe Kleine-König
> <u.kleine-koenig@...gutronix.de>
> Cc: linux-kernel@...r.kernel.org; linux-arm-kernel@...ts.infradead.org;
> linux-spi@...r.kernel.org; dl-linux-imx <linux-imx@....com>; Fabio Estevam
> <festevam@...il.com>; Pengutronix Kernel Team <kernel@...gutronix.de>;
> Sascha Hauer <s.hauer@...gutronix.de>; Shawn Guo
> <shawnguo@...nel.org>; Mark Brown <broonie@...nel.org>;
> dmaengine@...r.kernel.org; Vinod Koul <vkoul@...nel.org>; Dan Williams
> <dan.j.williams@...el.com>; Andy Duan <fugang.duan@....com>; Han Xu
> <han.xu@....com>; Clark Wang <xiaoning.wang@....com>
> Subject: RE: Issues with i.MX SPI DMA transfers
> 
> > -----Original Message-----
> > From: Igor Plyatov <plyatov@...il.com>
> > Sent: 2019年4月2日 15:20
> > To: Robin Gong <yibin.gong@....com>; Uwe Kleine-König
> > <u.kleine-koenig@...gutronix.de>
> > Cc: linux-kernel@...r.kernel.org;
> > linux-arm-kernel@...ts.infradead.org;
> > linux-spi@...r.kernel.org; dl-linux-imx <linux-imx@....com>; Fabio
> > Estevam <festevam@...il.com>; Pengutronix Kernel Team
> > <kernel@...gutronix.de>; Sascha Hauer <s.hauer@...gutronix.de>; Shawn
> > Guo <shawnguo@...nel.org>; Mark Brown <broonie@...nel.org>;
> > dmaengine@...r.kernel.org; Vinod Koul <vkoul@...nel.org>; Dan Williams
> > <dan.j.williams@...el.com>; Andy Duan <fugang.duan@....com>; Han Xu
> > <han.xu@....com>; Clark Wang <xiaoning.wang@....com>
> > Subject: Re: Issues with i.MX SPI DMA transfers
> >
> > Dear Robin Gong,
> >
> >
> > >> Sorry...below another sdma patch(ad0d92d7ba6a) need to be reverted,
> > >> because spi driver may dynamically change burst length.
> >
> >
> > now I have reverted patch ad0d92d7ba6a.
> >
> > Patches 0001-dma-engine-imx-sdma-add-mcu_2_ecspi-script.patch and
> > 0002-spi-spi-imx-fix-ERR009165.patch are applied.
> >
> >
> > Kernel log show messages
> >
> > [   29.202639] imx-sdma 20ec000.sdma: loaded firmware 3.3 [
> > 29.238595] spi_imx 2008000.spi: probed [   29.242802] spi_imx
> > 200c000.spi: probed [   29.245217] spi_imx 2018000.spi: probed
> >
> > SPI DMA transfers still not work.
> >
> > If I test 32 byte transfers, then they work fine. But 64 byte
> > transfers fails always and I see error messages
> >
> > root@cr7:~# spidev_test -D /dev/spidev4.1 -s 1200000 -b 8 -S 64 -I 1
> > -l spi mode: 0x20 bits per word: 8 max speed: 1200000 Hz (1200 KHz) [
> > 423.686736] spi_master spi4: I/O Error in DMA RX [  423.691392] spidev
> > spi4.1: SPI transfer failed: -110 [  423.696382] spi_master spi4:
> > failed to transfer one message from queue can't send spi message:
> > Connection timed out Aborted (core dumped)
> >
> > I suppose, transfers shorter then 64 bytes made with help of PIO.
> >
> > Robin, is there any chance for you to find some time and look at this
> > issue again?
> I have quick test with spidev_test loopback, but didn't meet your error, Is your
> code the almost latest code in linux-next as mine?
> 
> root@...6qpdlsolox:~# cat /proc/interrupts | grep sdma
>  48:         37       GPC   2 Level     sdma
>  -lt@...6qpdlsolox:~# ./spidev_test -D /dev/spidev0.0 -s 1200000 -b 8 -S 64 -I
> 1 -l spi mode: 0x20 bits per word: 8 max speed: 1200000 Hz (1200 KHz)
> root@...6qpdlsolox:~# cat /proc/interrupts | grep sdma
>  48:         43       GPC   2 Level     sdma
> ./spidev_test -D /dev/spidev0.0 -s 1200000 -b 8 -S 512 -I 1 -l spi mode: 0x20 bits
> per word: 8 max speed: 1200000 Hz (1200 KHz)
> total: tx 0.5KB, rx 0.5KB
> >
> > Best wishes.
> > --
> > Igor Plyatov

Download attachment "0005-dma-engine-imx-sdma-add-mcu_2_ecspi-script.patch" of type "application/octet-stream" (1369 bytes)

Download attachment "0006-spi-spi-imx-fix-ERR009165.patch" of type "application/octet-stream" (1635 bytes)