linux-kernel - Re: [PATCH] iio: adc: ti-ads7950: Fix build error without CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 10 Apr 2019 12:56:23 -0700
From:   Justin Chen <justinpopo6@...il.com>
To:     Yue Haibing <yuehaibing@...wei.com>
Cc:     Jonathan Cameron <jic23@...nel.org>, knaack.h@....de,
        lars@...afoo.de, Peter Meerwald-Stadler <pmeerw@...erw.net>,
        stefan.popa@...log.com, Mark Brown <broonie@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Jonathan.Cameron@...wei.com, linux-kernel@...r.kernel.org,
        linux-iio@...r.kernel.org
Subject: Re: [PATCH] iio: adc: ti-ads7950: Fix build error without CONFIG_GPIOLIB

On Wed, Apr 10, 2019 at 1:47 AM Yue Haibing <yuehaibing@...wei.com> wrote:
>
> From: YueHaibing <yuehaibing@...wei.com>
>
> When building with CONFIG_GPIOLIB is not set
> gcc warns this:
>
> drivers/iio/adc/ti-ads7950.c:75:19: error: field chip has incomplete type
>   struct gpio_chip chip;
>                    ^~~~
> drivers/iio/adc/ti-ads7950.c: In function ti_ads7950_set:
> drivers/iio/adc/ti-ads7950.c:409:32: error: implicit declaration of function gpiochip_get_data; did you mean acpi_get_data? [-Werror=implicit-function-declaration]
>   struct ti_ads7950_state *st = gpiochip_get_data(chip);
>                                 ^~~~~~~~~~~~~~~~~
>                                 acpi_get_data
>
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Fixes: c97dce792dc8 ("iio: adc: ti-ads7950: add GPIO support")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
Reviewed-by: Justin Chen <justinpopo6@...il.com>

Thanks,
Justin
> ---
>  drivers/iio/adc/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index 846c7ac..f760269 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -968,7 +968,7 @@ config TI_ADS1015
>
>  config TI_ADS7950
>         tristate "Texas Instruments ADS7950 ADC driver"
> -       depends on SPI
> +       depends on SPI && GPIOLIB
>         select IIO_BUFFER
>         select IIO_TRIGGERED_BUFFER
>         help
> --
> 2.7.4
>
>