linux-kernel - Re: [PATCH] mtd: cfi_cmdset_0002: Mark expected switch fall-throughs

Open Source and information security mailing list archives

Message-ID: <4e83c8d7-8d21-10ae-3cf4-5fbaa7b98cf4@embeddedor.com>
Date:   Wed, 10 Apr 2019 16:15:19 -0500
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Tokunori Ikegami <ikegami.t@...il.com>,
        'David Woodhouse' <dwmw2@...radead.org>,
        'Brian Norris' <computersforpeace@...il.com>,
        'Boris Brezillon' <bbrezillon@...nel.org>,
        'Marek Vasut' <marek.vasut@...il.com>,
        'Richard Weinberger' <richard@....at>
Cc:     linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Kees Cook <keescook@...omium.org>
Subject: Re: [PATCH] mtd: cfi_cmdset_0002: Mark expected switch fall-throughs

Hi all,

If no one cares I'll add this to my tree for 5.2.

Thanks
--
Gustavo

On 3/20/19 3:16 PM, Gustavo A. R. Silva wrote:
> Hi all,
> 
> Friendly ping:
> 
> Who can take this?
> 
> Thanks
> --
> Gustavo
> 
> On 2/9/19 2:29 AM, Tokunori Ikegami wrote:
>> Reviewed-by: Tokunori Ikegami <ikegami.t@...il.com>
>>
>>> -----Original Message-----
>>> From: linux-mtd [mailto:linux-mtd-bounces@...ts.infradead.org] On Behalf
>>> Of Gustavo A. R. Silva
>>> Sent: Saturday, February 9, 2019 3:06 AM
>>> To: David Woodhouse; Brian Norris; Boris Brezillon; Marek Vasut; Richard
>>> Weinberger
>>> Cc: linux-mtd@...ts.infradead.org; linux-kernel@...r.kernel.org; Gustavo
>>> A. R. Silva
>>> Subject: [PATCH] mtd: cfi_cmdset_0002: Mark expected switch fall-throughs
>>>
>>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>>> cases where we are expecting to fall through.
>>>
>>> This patch fixes the following warnings:
>>>
>>> drivers/mtd/chips/cfi_cmdset_0002.c: In function ‘get_chip’:
>>> drivers/mtd/chips/cfi_cmdset_0002.c:870:6: warning: this statement may
>>> fall through [-Wimplicit-fallthrough=]
>>>    if (mode == FL_READY && chip->oldstate == FL_READY)
>>>       ^
>>> drivers/mtd/chips/cfi_cmdset_0002.c:873:2: note: here
>>>   default:
>>>   ^~~~~~~
>>> drivers/mtd/chips/cfi_cmdset_0002.c: In function ‘cfi_amdstd_sync’:
>>> drivers/mtd/chips/cfi_cmdset_0002.c:2745:16: warning: this statement may
>>> fall through [-Wimplicit-fallthrough=]
>>>     chip->state = FL_SYNCING;
>>>     ~~~~~~~~~~~~^~~~~~~~~~~~
>>> drivers/mtd/chips/cfi_cmdset_0002.c:2750:3: note: here
>>>    case FL_SYNCING:
>>>    ^~~~
>>>
>>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>>
>>> This patch is part of the ongoing efforts to enabling
>>> -Wimplicit-fallthrough.
>>>
>>> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
>>> ---
>>>  drivers/mtd/chips/cfi_cmdset_0002.c | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c
>>> b/drivers/mtd/chips/cfi_cmdset_0002.c
>>> index 72428b6bfc47..0b0a1874d3bf 100644
>>> --- a/drivers/mtd/chips/cfi_cmdset_0002.c
>>> +++ b/drivers/mtd/chips/cfi_cmdset_0002.c
>>> @@ -869,6 +869,7 @@ static int get_chip(struct map_info *map, struct flchip
>>> *chip, unsigned long adr
>>>  		/* Only if there's no operation suspended... */
>>>  		if (mode == FL_READY && chip->oldstate == FL_READY)
>>>  			return 0;
>>> +		/* fall through */
>>>
>>>  	default:
>>>  	sleep:
>>> @@ -2747,6 +2748,7 @@ static void cfi_amdstd_sync (struct mtd_info *mtd)
>>>  			 * as the whole point is that nobody can do anything
>>>  			 * with the chip now anyway.
>>>  			 */
>>> +			/* fall through */
>>>  		case FL_SYNCING:
>>>  			mutex_unlock(&chip->mutex);
>>>  			break;
>>> --
>>> 2.20.1
>>>
>>>
>>> ______________________________________________________
>>> Linux MTD discussion mailing list
>>> http://lists.infradead.org/mailman/listinfo/linux-mtd/
>>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives