linux-kernel - Re: [PATCH 12/27] x86/pkru: Provide .*_pkru

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6f22b890-a3f7-f758-e955-384c17e6e4bb@intel.com>
Date:   Wed, 10 Apr 2019 14:29:26 -0700
From:   Dave Hansen <dave.hansen@...el.com>
To:     Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Borislav Petkov <bp@...en8.de>
Cc:     Dave Hansen <dave.hansen@...ux.intel.com>,
        linux-kernel@...r.kernel.org, x86@...nel.org,
        Andy Lutomirski <luto@...nel.org>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Radim Krčmář <rkrcmar@...hat.com>,
        kvm@...r.kernel.org, "Jason A. Donenfeld" <Jason@...c4.com>,
        Rik van Riel <riel@...riel.com>
Subject: Re: [PATCH 12/27] x86/pkru: Provide .*_pkru_ins() functions

On 4/10/19 2:25 PM, Sebastian Andrzej Siewior wrote:
>>  static inline void write_pkru(u32 pkru)
>>  {
>>  	if (boot_cpu_has(X86_FEATURE_OSPKE))
>> -		__write_pkru(pkru);
>> +		wrpkru(pkru);
> I think if this is a simple
> 
>    's@...rite_pkru_ins@...kru@g'
>    's@...ead_pkru_ins@...kru@g'
> 
> then it should work just fine and match what Dave asked for.

I'm fine with it either way, fwiw.