lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <155493683173.20095.12913107010666279046@swboyd.mtv.corp.google.com>
Date:   Wed, 10 Apr 2019 15:53:51 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Nicholas Mc Guire <hofrat@...ntech.at>,
        Ulf Hansson <ulf.hansson@...aro.org>
Cc:     Michael Turquette <mturquette@...libre.com>,
        linux-arm-kernel@...ts.infradead.org, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Nicholas Mc Guire <hofrat@...ntech.at>
Subject: Re: [PATCH RFC] clk: ux500: add range to usleep_range

Quoting Nicholas Mc Guire (2019-04-06 20:13:24)
> Providing a range for usleep_range() allows the hrtimer subsystem to
> coalesce timers - the delay is runtime configurable so a factor 2
> is taken to provide the range.
> 
> Signed-off-by: Nicholas Mc Guire <hofrat@...ntech.at>
> ---

I think this driver is in maintenance mode. I'll wait for Ulf to ack or
review this change before applying.

> diff --git a/drivers/clk/ux500/clk-sysctrl.c b/drivers/clk/ux500/clk-sysctrl.c
> index 7c0403b..a1fa3fb 100644
> --- a/drivers/clk/ux500/clk-sysctrl.c
> +++ b/drivers/clk/ux500/clk-sysctrl.c
> @@ -42,7 +42,7 @@ static int clk_sysctrl_prepare(struct clk_hw *hw)
>                                 clk->reg_bits[0]);
>  
>         if (!ret && clk->enable_delay_us)
> -               usleep_range(clk->enable_delay_us, clk->enable_delay_us);
> +               usleep_range(clk->enable_delay_us, clk->enable_delay_us*2);

Please add space around that multiply.

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ