linux-kernel - [PATCH] io_uring: fix ifnullfree.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 10 Apr 2019 08:16:54 +0200 (CEST)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     Jianchao Wang <jianchao.w.wang@...cle.com>
cc:     axboe@...nel.dk, viro@...iv.linux.org.uk,
        linux-block@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org, kbuild-all@...org
Subject: [PATCH] io_uring: fix ifnullfree.cocci warnings

From: kbuild test robot <lkp@...el.com>

NULL check before kfree is not needed.

Generated by: scripts/coccinelle/free/ifnullfree.cocci

Fixes: b905f31ee046 ("io_uring: introduce inline reqs for IORING_SETUP_IOPOLL")
CC: Jianchao Wang <jianchao.w.wang@...cle.com>
Signed-off-by: kbuild test robot <lkp@...el.com>
Signed-off-by: Julia Lawall <julia.lawall@...6.fr>

---

url:    https://github.com/0day-ci/linux/commits/Jianchao-Wang/io_uring-introduce-inline-reqs-for-IORING_SETUP_IOPOLL/20190409-194746
:::::: branch date: 17 hours ago
:::::: commit date: 17 hours ago

 io_uring.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -2597,8 +2597,7 @@ static void io_ring_ctx_free(struct io_r
 		sock_release(ctx->ring_sock);
 #endif

-	if (ctx->inline_req_array)
-		kfree(ctx->inline_req_array);
+	kfree(ctx->inline_req_array);

 	io_mem_free(ctx->sq_ring);
 	io_mem_free(ctx->sq_sqes);