linux-kernel - RE: [PATCH v2 1/1] spi: pxa2xx: add driver enabling message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <29d4b981e6224ee89db90bf71bdbf7e1@asem.it>
Date:   Wed, 10 Apr 2019 10:16:14 +0000
From:   Flavio Suligoi <f.suligoi@...m.it>
To:     Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
        Daniel Mack <daniel@...que.org>,
        Haojian Zhuang <haojian.zhuang@...il.com>,
        "Robert Jarzmik" <robert.jarzmik@...e.fr>,
        Mark Brown <broonie@...nel.org>
CC:     "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-spi@...r.kernel.org" <linux-spi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2 1/1] spi: pxa2xx: add driver enabling message

> On 4/10/19 12:47 PM, Flavio Suligoi wrote:
> > Add an info message for the PXA2xx device driver start-up,
> > with the indication of:
> >
> > - mode (slave device or master controller)
> > - transfer mode (DMA or GPIO)
> >
> > Signed-off-by: Flavio Suligoi <f.suligoi@...m.it>
> > ---
> >
> > v1:	- first version
> > v2:	- remove warning message "no DMA channels available, using PIO"
> > 	- add "slave device"/"master controller" indication message
> >
> >   drivers/spi/spi-pxa2xx.c | 5 ++++-
> >   1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c
> > index f7068cc..b9e04e2 100644
> > --- a/drivers/spi/spi-pxa2xx.c
> > +++ b/drivers/spi/spi-pxa2xx.c
> > @@ -1696,7 +1696,6 @@ static int pxa2xx_spi_probe(struct platform_device
> *pdev)
> >   	if (platform_info->enable_dma) {
> >   		status = pxa2xx_spi_dma_setup(drv_data);
> >   		if (status) {
> > -			dev_warn(dev, "no DMA channels available, using PIO\n");
> >   			platform_info->enable_dma = false;
> >   		} else {
> >   			controller->can_dma = pxa2xx_spi_can_dma;
> > @@ -1818,6 +1817,10 @@ static int pxa2xx_spi_probe(struct
> platform_device *pdev)
> >   	pm_runtime_set_active(&pdev->dev);
> >   	pm_runtime_enable(&pdev->dev);
> >
> > +	dev_info(dev, "PXA2xx SPI %s (%s mode)\n",
> > +		platform_info->is_slave ? "slave device" : "master
> controller",
> > +		platform_info->enable_dma ? "DMA" : "PIO");
> > +
> 
> "slave device" is ambiguous. Please use "controller" with both, i.e.
> "PXA2xx SPI %s controller (%s mode)\n", ... ? "slave" : "master", ...
> 
> With that changed you may add:
> 
> Reviewed-by: Jarkko Nikula <jarkko.nikula@...ux.intel.com>

Ok

Flavio