linux-kernel - Re: [PATCH 2/3] ASoC: add hikey960-i2s DT bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190410111032.GJ6106@sirena.org.uk>
Date:   Wed, 10 Apr 2019 12:10:32 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Pengcheng Li <lipengcheng8@...wei.com>
Cc:     lgirdwood@...il.com, perex@...ex.cz, tiwai@...e.com,
        john.stultz@...aro.org, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org, suzhuangluan@...ilicon.com,
        kongfei@...ilicon.com, liyuequan@...ilicon.com,
        cash.qianli@...ilicon.com, huangli295@...ilicon.com,
        hantanglei@...wei.com, wangyoulin1@...ilicon.com,
        ninggaoyu@...ilicon.com, xuwei5@...wei.com
Subject: Re: [PATCH 2/3] ASoC: add hikey960-i2s DT bindings

On Thu, Feb 28, 2019 at 09:57:41PM +0800, Pengcheng Li wrote:

> +Required properties:
> +
> +- compatible: should be one of the following:
> +   - "hisilicon,hi3660-i2s-1.0"
> +- reg: physical base address of the i2s controller unit and length of
> +   memory mapped region.

This binding is inaccurate for the code as it requires two memory
regions, one for the IP and one for the system controller.  However as I
said in the review of the driver you should probably be using the
standard syscon binding for the system controller.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)