linux-kernel - Re: [PATCH v2 net-next 07/22] ether: Add dedicated Ethertype for pseudo-802.1Q DSA tagging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <613d43d9-5331-3b1c-c044-a1dcf0bf21e2@gmail.com>
Date:   Tue, 9 Apr 2019 19:04:26 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vladimir Oltean <olteanv@...il.com>, vivien.didelot@...il.com,
        andrew@...n.ch, davem@...emloft.net
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        georg.waibel@...sor-technik.de
Subject: Re: [PATCH v2 net-next 07/22] ether: Add dedicated Ethertype for
 pseudo-802.1Q DSA tagging



On 4/9/2019 5:56 PM, Vladimir Oltean wrote:
> With the newly added DSA_TAG_PROTO_8021Q, switch devices that don't
> support a native insertion/extraction header on the CPU port may still
> enjoy the benefits of port isolation with a custom VLAN tag.
> 
> For this, they need to have a customizable TPID in hardware and a new
> Ethertype to distinguish between real 802.1Q traffic and the private
> tags used for port separation.
> 
> Signed-off-by: Vladimir Oltean <olteanv@...il.com>

Why was not using ETH_P_EDSA not suitable? Also how do we intend to use
this from user-space? The latest libpcap/tcpdump changes essentially
look at the dsa/tagging sysfs attribute for the master network device to
determine what type of underlying tagging protocol is used, since you
allocated a new one (NET_DSA_TAG_8021Q) you could have added a matching
string in sysfs so we can recognize it?
-- 
Florian