linux-kernel - Re: [PATCH v3 0/4] perf: Support a new 'percore' event qualifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56d48bbb-456d-b62f-bda8-a6e84b1632f9@linux.intel.com>
Date:   Wed, 10 Apr 2019 10:32:13 +0800
From:   "Jin, Yao" <yao.jin@...ux.intel.com>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     acme@...nel.org, jolsa@...nel.org, peterz@...radead.org,
        mingo@...hat.com, alexander.shishkin@...ux.intel.com,
        Linux-kernel@...r.kernel.org, ak@...ux.intel.com,
        kan.liang@...el.com, yao.jin@...el.com
Subject: Re: [PATCH v3 0/4] perf: Support a new 'percore' event qualifier

Hi Arnaldo,

Can this patch be accepted?

Thanks
Jin Yao

On 3/19/2019 6:20 PM, Jiri Olsa wrote:
> On Tue, Mar 19, 2019 at 04:56:52PM +0800, Jin Yao wrote:
>> The 'percore' event qualifier which sums up the event counts for both
>> hardware threads in a core. For example,
>>
>> perf stat -e cpu/event=0,umask=0x3,percore=1/,cpu/event=0,umask=0x3/
>>
>> In this example, we count the event 'ref-cycles' per-core and per-CPU in
>> one perf stat command-line.
>>
>> We can already support per-core counting with --per-core, but it's
>> often useful to do this together with other metrics that are collected
>> per CPU (per hardware thread). So this patch series supports this
>> per-core counting on a event level.
>>
>>   v3:
>>   ---
>>   Simplify the patch: "perf: Add a 'percore' event qualifier"
>>   Other patches don't have changes.
> 
> Acked-by: Jiri Olsa <jolsa@...nel.org>
> 
> thanks,
> jirka
> 
>>
>>   v2:
>>   ---
>>   1. Change 'coresum' to 'percore'.
>>   2. Move the aggregate counts printing to a seperate patch.
>>
>> Jin Yao (4):
>>    perf: Add a 'percore' event qualifier
>>    perf stat: Factor out aggregate counts printing
>>    perf stat: Support 'percore' event qualifier
>>    perf test: Add a simple test for term 'percore'
>>
>>   tools/perf/Documentation/perf-stat.txt |   4 ++
>>   tools/perf/builtin-stat.c              |  21 +++++++
>>   tools/perf/tests/parse-events.c        |  10 ++-
>>   tools/perf/util/evsel.c                |   2 +
>>   tools/perf/util/evsel.h                |   3 +
>>   tools/perf/util/parse-events.c         |  27 +++++++++
>>   tools/perf/util/parse-events.h         |   1 +
>>   tools/perf/util/parse-events.l         |   1 +
>>   tools/perf/util/stat-display.c         | 108 ++++++++++++++++++++++++---------
>>   tools/perf/util/stat.c                 |   8 ++-
>>   10 files changed, 151 insertions(+), 34 deletions(-)
>>
>> -- 
>> 2.7.4
>>