linux-kernel - Re: [PATCH] firmware: arm_scmi: check return value of idr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190410162537.GF3952@e107155-lin>
Date:   Wed, 10 Apr 2019 17:25:37 +0100
From:   Sudeep Holla <sudeep.holla@....com>
To:     Kangjie Lu <kjlu@....edu>
Cc:     pakki001@....edu, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, Sudeep Holla <sudeep.holla@....com>
Subject: Re: [PATCH] firmware: arm_scmi: check return value of idr_find

On Fri, Mar 08, 2019 at 10:02:39PM -0600, Kangjie Lu wrote:
> idr_find may return NULL, so check its return value and return an
> error code.
> 

I can't imagine a scenario leading to this. Steven has already explained
why, so I won't repeat the same here. Did you hit this issue ?

If so I would like to know details, so that we can bail out much earlier
where the failure occurs than proceed until this point.

--
Regards,
Sudeep