lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 10 Apr 2019 09:53:20 -0700 From: Stephen Boyd <sboyd@...nel.org> To: Jeffrey Hugo <jhugo@...eaurora.org>, Michael Turquette <mturquette@...libre.com> Cc: linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org, Miquel Raynal <miquel.raynal@...tlin.com>, Jerome Brunet <jbrunet@...libre.com>, Russell King <linux@...linux.org.uk>, Chen-Yu Tsai <wens@...e.org>, Rob Herring <robh@...nel.org> Subject: Re: [PATCH v3 3/7] clk: Add of_clk_hw_register() API for early clk drivers Quoting Jeffrey Hugo (2019-04-08 14:46:11) > On 4/4/2019 3:53 PM, Stephen Boyd wrote: > > In some circumstances drivers register clks early and don't have access > > to a struct device because the device model isn't initialized yet. Add > > an API to let drivers register clks associated with a struct device_node > > so that these drivers can participate in getting parent clks through DT. > > NACK. This patch broke boot for me. I had to pull the below from JTAG. > What do you need to debug this? > Here's a patch to try to squash in: ---8<---- diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index 709492d901a1..040ce083c89e 100644 --- a/drivers/clk/clk.c +++ b/drivers/clk/clk.c @@ -3662,7 +3662,7 @@ __clk_register(struct device *dev, struct device_node *np, struct clk_hw *hw) */ struct clk *clk_register(struct device *dev, struct clk_hw *hw) { - return __clk_register(dev, dev->of_node, hw); + return __clk_register(dev, dev_of_node(dev), hw); } EXPORT_SYMBOL_GPL(clk_register); @@ -3678,7 +3678,7 @@ EXPORT_SYMBOL_GPL(clk_register); */ int clk_hw_register(struct device *dev, struct clk_hw *hw) { - return PTR_ERR_OR_ZERO(__clk_register(dev, dev->of_node, hw)); + return PTR_ERR_OR_ZERO(__clk_register(dev, dev_of_node(dev), hw)); } EXPORT_SYMBOL_GPL(clk_hw_register);
Powered by blists - more mailing lists