linux-kernel - [PATCH 2/4] mtd: rawnand: meson: use of_property_count_elems_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190411220056.19109-3-martin.blumenstingl@googlemail.com>
Date:   Fri, 12 Apr 2019 00:00:54 +0200
From:   Martin Blumenstingl <martin.blumenstingl@...glemail.com>
To:     liang.yang@...ogic.com, linux-amlogic@...ts.infradead.org,
        linux-mtd@...ts.infradead.org, richard@....at,
        miquel.raynal@...tlin.com
Cc:     linux-arm-kernel@...ts.infradead.org, marek.vasut@...il.com,
        linux-kernel@...r.kernel.org, computersforpeace@...il.com,
        dwmw2@...radead.org, bbrezillon@...nel.org,
        jianxin.pan@...ogic.com,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>
Subject: [PATCH 2/4] mtd: rawnand: meson: use of_property_count_elems_of_size helper

Use the of_property_count_elems_of_size() helper instead of open-coding
it's logic. As a bonus this will now error out if the "reg" property
values use an incorrect size (anything other than sizeof(u32)).

Signed-off-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
---
 drivers/mtd/nand/raw/meson_nand.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c
index c1a6af57dab5..9a6023638101 100644
--- a/drivers/mtd/nand/raw/meson_nand.c
+++ b/drivers/mtd/nand/raw/meson_nand.c
@@ -1233,10 +1233,7 @@ meson_nfc_nand_chip_init(struct device *dev,
 	int ret, i;
 	u32 tmp, nsels;
 
-	if (!of_get_property(np, "reg", &nsels))
-		return -EINVAL;
-
-	nsels /= sizeof(u32);
+	nsels = of_property_count_elems_of_size(np, "reg", sizeof(u32));
 	if (!nsels || nsels > MAX_CE_NUM) {
 		dev_err(dev, "invalid register property size\n");
 		return -EINVAL;
-- 
2.21.0