linux-kernel - Re: [PATCH v1 00/15] Refactor pgalloc stuff

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <87wok13zbg.fsf@linux.ibm.com>
Date:   Thu, 11 Apr 2019 10:36:59 +0530
From:   "Aneesh Kumar K.V" <aneesh.kumar@...ux.ibm.com>
To:     Christophe Leroy <christophe.leroy@....fr>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Paul Mackerras <paulus@...ba.org>,
        Michael Ellerman <mpe@...erman.id.au>
Cc:     linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 00/15] Refactor pgalloc stuff

Christophe Leroy <christophe.leroy@....fr> writes:

> This series converts book3e64 to pte_fragment and refactor
> things that are common among subarches.
>
> Christophe Leroy (15):
>   powerpc/mm: drop __bad_pte()
>   powerpc/mm: define __pud_free_tlb() at all time on nohash/64
>   powerpc/mm: convert Book3E 64 to pte_fragment
>   powerpc/mm: move pgtable_t in asm/mmu.h
>   powerpc/mm: get rid of nohash/32/mmu.h and nohash/64/mmu.h
>   powerpc/Kconfig: select PPC_MM_SLICES from subarch type
>   powerpc/book3e: move early_alloc_pgtable() to init section
>   powerpc/mm: don't use pte_alloc_kernel() until slab is available on
>     PPC32
>   powerpc/mm: inline pte_alloc_one_kernel() and pte_alloc_one() on PPC32
>   powerpc/mm: refactor pte_alloc_one() and pte_free() families
>     definition.
>   powerpc/mm: refactor definition of pgtable_cache[]
>   powerpc/mm: Only keep one version of pmd_populate() functions on
>     nohash/32
>   powerpc/mm: refactor pgtable freeing functions on nohash
>   powerpc/mm: refactor pmd_pgtable()
>   powerpc/mm: refactor pgd_alloc() and pgd_free() on nohash
>
>  arch/powerpc/include/asm/book3s/32/mmu-hash.h |   4 -
>  arch/powerpc/include/asm/book3s/32/pgalloc.h  |  41 ---------
>  arch/powerpc/include/asm/book3s/64/mmu.h      |   8 --
>  arch/powerpc/include/asm/book3s/64/pgalloc.h  |  49 ----------
>  arch/powerpc/include/asm/mmu.h                |   3 +
>  arch/powerpc/include/asm/mmu_context.h        |   6 --
>  arch/powerpc/include/asm/nohash/32/mmu.h      |  25 ------
>  arch/powerpc/include/asm/nohash/32/pgalloc.h  | 123 ++------------------------
>  arch/powerpc/include/asm/nohash/64/mmu.h      |  12 ---
>  arch/powerpc/include/asm/nohash/64/pgalloc.h  | 117 +-----------------------
>  arch/powerpc/include/asm/nohash/mmu.h         |  16 +++-
>  arch/powerpc/include/asm/nohash/pgalloc.h     |  56 ++++++++++++
>  arch/powerpc/include/asm/pgalloc.h            |  51 +++++++++++
>  arch/powerpc/mm/Makefile                      |   4 +-
>  arch/powerpc/mm/mmu_context.c                 |   2 +-
>  arch/powerpc/mm/pgtable-book3e.c              |   4 +-
>  arch/powerpc/mm/pgtable_32.c                  |  42 +++++----
>  arch/powerpc/platforms/Kconfig.cputype        |   4 +-
>  18 files changed, 165 insertions(+), 402 deletions(-)
>  delete mode 100644 arch/powerpc/include/asm/nohash/32/mmu.h
>  delete mode 100644 arch/powerpc/include/asm/nohash/64/mmu.h
>
> -- 
> 2.13.3

Looks good. You can add for the series

Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@...ux.ibm.com>