linux-kernel - Re: [PATCH] ARM: dts: imx6qdl-udoo: Add Pincfgs for OTG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190411065440.GB26817@dragon>
Date:   Thu, 11 Apr 2019 14:54:42 +0800
From:   Shawn Guo <shawnguo@...nel.org>
To:     Markus Kueffner <kueffner.markus@...il.com>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: dts: imx6qdl-udoo: Add Pincfgs for OTG

On Sat, Apr 06, 2019 at 06:00:20PM +0200, Markus Kueffner wrote:
> Add Pincfgs to enable the i.MX6's OTG feature for UDOO
> 
> Signed-off-by: Markus Kueffner <kueffner.markus@...il.com>
> ---
>  arch/arm/boot/dts/imx6qdl-udoo.dtsi | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-udoo.dtsi b/arch/arm/boot/dts/imx6qdl-udoo.dtsi
> index 776bfc7..42954ee 100644
> --- a/arch/arm/boot/dts/imx6qdl-udoo.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-udoo.dtsi
> @@ -221,6 +221,14 @@
>  			>;
>  		};
>  
> +		pinctrl_usbotg: usbotg {
> +			fsl,pins = <
> +				MX6QDL_PAD_GPIO_1__USB_OTG_ID 0x17059
> +				MX6QDL_PAD_EIM_D22__USB_OTG_PWR 0x17059
> +				MX6QDL_PAD_EIM_D21__USB_OTG_OC 0x17059
> +			>;
> +		};
> +

I know ac97 is out of order, but I still would like to keep pinctrl
nodes sort alphabetically.  That said, pinctrl_usbotg should go after
pinctrl_usbh.

>  		pinctrl_ac97_running: ac97running {
>  			fsl,pins = <
>  				MX6QDL_PAD_DI0_PIN2__AUD6_TXD		0x1b0b0
> @@ -294,6 +302,14 @@
>  	status = "okay";
>  };
>  
> +&usbotg {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_usbotg>;
> +	fsl,power-line-polarity-active-high;
> +	fsl,over-current-polarity-active-low;

Are these two properties supported by upstream bindings and driver?

Shawn

> +	status = "okay";
> +};
> +
>  &audmux {
>  	status = "okay";
>  };
> -- 
> 2.1.4
>