lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Thu, 11 Apr 2019 08:01:55 +0000
From:   Andy Tang <andy.tang@....com>
To:     Daniel Lezcano <daniel.lezcano@...aro.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>
CC:     Leo Li <leoyang.li@....com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "rui.zhang@...el.com" <rui.zhang@...el.com>,
        "edubezval@...il.com" <edubezval@...il.com>
Subject: RE: [PATCH v4] arm64: dts: ls1088a: add one more thermal zone node

Hi Daniel,


> -----Original Message-----
> From: Daniel Lezcano <daniel.lezcano@...aro.org>
> Sent: 2019年4月4日 10:35
> To: Andy Tang <andy.tang@....com>; shawnguo@...nel.org
> Cc: Leo Li <leoyang.li@....com>; robh+dt@...nel.org; mark.rutland@....com;
> linux-arm-kernel@...ts.infradead.org; devicetree@...r.kernel.org;
> linux-kernel@...r.kernel.org; linux-pm@...r.kernel.org; rui.zhang@...el.com;
> edubezval@...il.com
> Subject: Re: [PATCH v4] arm64: dts: ls1088a: add one more thermal zone node
> > +						<&cpu1 THERMAL_NO_LIMIT
> THERMAL_NO_LIMIT>,
> > +						<&cpu2 THERMAL_NO_LIMIT
> THERMAL_NO_LIMIT>,
> > +						<&cpu3 THERMAL_NO_LIMIT
> THERMAL_NO_LIMIT>,
> > +						<&cpu4 THERMAL_NO_LIMIT
> THERMAL_NO_LIMIT>,
> > +						<&cpu5 THERMAL_NO_LIMIT
> THERMAL_NO_LIMIT>,
> > +						<&cpu6 THERMAL_NO_LIMIT
> THERMAL_NO_LIMIT>,
> > +						<&cpu7 THERMAL_NO_LIMIT
> THERMAL_NO_LIMIT>;
> > +				};
> 
> Does it make sense to assign the same cooling devices to two different thermal
> zones running different instances of governor ?
Even though I didn't find any error when test, I do think it is inappropriate.

BR,
Andy
> 
> > +			};
> > +		};
> > +
> > +		platform-thermal {
> > +			polling-delay-passive = <1000>;
> > +			polling-delay = <5000>;
> > +			thermal-sensors = <&tmu 1>;
> > +
> > +			trips {
> > +				platform_alert: platform-alert {
> > +					temperature = <85000>;
> > +					hysteresis = <2000>;
> > +					type = "passive";
> > +				};
> > +
> > +				platform_crit: platform-crit {
> > +					temperature = <95000>;
> > +					hysteresis = <2000>;
> > +					type = "critical";
> > +				};
> > +			};
> > +
> > +			cooling-maps {
> > +				map0 {
> > +					trip = <&platform_alert>;
> >  					cooling-device =
> >  						<&cpu0 THERMAL_NO_LIMIT
> THERMAL_NO_LIMIT>,
> >  						<&cpu1 THERMAL_NO_LIMIT
> THERMAL_NO_LIMIT>,
> >
> 
> 
> --
> 
> <https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.lin
> aro.org%2F&amp;data=02%7C01%7Candy.tang%40nxp.com%7Ce1b704832ea34
> 6ae738408d6b8a6283f%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C
> 636899421110441574&amp;sdata=C7mrUztObkHMZyqEJg53h99SdIweJSeKhi8l
> %2BQpUQhA%3D&amp;reserved=0> Linaro.org │ Open source software for
> ARM SoCs
> 
> Follow Linaro:
> <https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.fac
> ebook.com%2Fpages%2FLinaro&amp;data=02%7C01%7Candy.tang%40nxp.com
> %7Ce1b704832ea346ae738408d6b8a6283f%7C686ea1d3bc2b4c6fa92cd99c5c30
> 1635%7C0%7C0%7C636899421110441574&amp;sdata=Pxj%2Blfc%2FC1KiQBD0
> kzTjQGT2AgjCbYlcXhnscWTb6pw%3D&amp;reserved=0> Facebook |
> <https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Ftwitter.c
> om%2F%23!%2Flinaroorg&amp;data=02%7C01%7Candy.tang%40nxp.com%7Ce
> 1b704832ea346ae738408d6b8a6283f%7C686ea1d3bc2b4c6fa92cd99c5c301635
> %7C0%7C0%7C636899421110441574&amp;sdata=YJQRgMTwcG%2B3H1g%2FX
> h3zaw%2BXy8OdlstL5AH4R0eXmN8%3D&amp;reserved=0> Twitter |
> <https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.lin
> aro.org%2Flinaro-blog%2F&amp;data=02%7C01%7Candy.tang%40nxp.com%7C
> e1b704832ea346ae738408d6b8a6283f%7C686ea1d3bc2b4c6fa92cd99c5c30163
> 5%7C0%7C0%7C636899421110441574&amp;sdata=rlkO6mkHgdam8K2RTwsOf
> 8ExPF2KRy%2FrMwwyshRBKAg%3D&amp;reserved=0> Blog

Powered by blists - more mailing lists