lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20190411085316.GG3050@dragon> Date: Thu, 11 Apr 2019 16:53:17 +0800 From: Shawn Guo <shawnguo@...nel.org> To: Guenter Roeck <linux@...ck-us.net> Cc: Wim Van Sebroeck <wim@...ux-watchdog.org>, linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org, Jun Nie <jun.nie@...aro.org> Subject: Re: [PATCH 12/22] watchdog: zx2967_wdt: Convert to use device managed functions and other improvements On Wed, Apr 10, 2019 at 09:27:53AM -0700, Guenter Roeck wrote: > Use device managed functions to simplify error handling, reduce > source code size, improve readability, and reduce the likelyhood of bugs. > Other improvements as listed below. > > The conversion was done automatically with coccinelle using the > following semantic patches. The semantic patches and the scripts > used to generate this commit log are available at > https://github.com/groeck/coccinelle-patches > > - Drop assignments to otherwise unused variables > - Drop empty remove function > - Use devm_add_action_or_reset() for calls to clk_disable_unprepare > - Use local variable 'struct device *dev' consistently > - Use devm_watchdog_register_driver() to register watchdog device > > Cc: Jun Nie <jun.nie@...aro.org> > Cc: Shawn Guo <shawnguo@...nel.org> > Signed-off-by: Guenter Roeck <linux@...ck-us.net> Acked-by: Shawn Guo <shawnguo@...nel.org>
Powered by blists - more mailing lists