linux-kernel - Re: [PATCH v2] modpost: make KBUILD_MODPOST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fe53aa37-7570-8f5f-2114-337fd1d1eedc@nokia.com>
Date:   Thu, 11 Apr 2019 09:28:47 +0000
From:   "Wiebe, Wladislav (Nokia - DE/Ulm)" <wladislav.wiebe@...ia.com>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>,
        "michal.lkml@...kovi.net" <michal.lkml@...kovi.net>,
        "linux-kbuild@...r.kernel.org" <linux-kbuild@...r.kernel.org>,
        Jonas Gorski <jonas.gorski@...il.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] modpost: make KBUILD_MODPOST_WARN also configurable
 for

seems subject is incomplete in v2, v3 posted:
https://lore.kernel.org/patchwork/patch/1060505/

Thanks!

- Wladislav

On 10.04.2019 11:23, Wiebe, Wladislav (Nokia - DE/Ulm) wrote:
> Commit ea837f1c0503 ("kbuild: make modpost processing configurable")
> was intended to give KBUILD_MODPOST_WARN flexibility to be configurable.
> Right now KBUILD_MODPOST_WARN gets just ignored when KBUILD_EXTMOD is
> set which happens per default when building modules out of the tree.
> 
> This change gives the opportunity to define module build behaving also
> in case of out of tree builds and default will become exit on error.
> Errors which can be detected by the build should be trapped out of the box
> there, unless somebody wants to notice broken stuff later at runtime.
> 
> As this patch changes the default behaving from warning to error,
> users can consider to fix it for external module builds by:
> - providing module symbol table via KBUILD_EXTRA_SYMBOLS for
>    modules which are dependent
> - OR getting old behaving back by passing KBUILD_MODPOST_WARN to the build
> 
> Signed-off-by: Wladislav Wiebe <wladislav.wiebe@...ia.com>
> ---
>   scripts/Makefile.modpost | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/Makefile.modpost b/scripts/Makefile.modpost
> index 6b7f354f189a..fec6ec2ffa47 100644
> --- a/scripts/Makefile.modpost
> +++ b/scripts/Makefile.modpost
> @@ -78,7 +78,7 @@ modpost = scripts/mod/modpost                    \
>    $(if $(KBUILD_EXTRA_SYMBOLS), $(patsubst %, -e %,$(KBUILD_EXTRA_SYMBOLS))) \
>    $(if $(KBUILD_EXTMOD),-o $(modulesymfile))      \
>    $(if $(CONFIG_SECTION_MISMATCH_WARN_ONLY),,-E)  \
> - $(if $(KBUILD_EXTMOD)$(KBUILD_MODPOST_WARN),-w)
> + $(if $(KBUILD_MODPOST_WARN),-w)
>   
>   MODPOST_OPT=$(subst -i,-n,$(filter -i,$(MAKEFLAGS)))
>   
>