lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAPDyKFq8icX27w2FaLgTWtdV1MicfVO+rG_5sZT9n-5pT7iAWg@mail.gmail.com> Date: Thu, 11 Apr 2019 13:01:17 +0200 From: Ulf Hansson <ulf.hansson@...aro.org> To: YueHaibing <yuehaibing@...wei.com> Cc: Will Deacon <will.deacon@....com>, Jens Axboe <axboe@...nel.dk>, Omar Sandoval <osandov@...com>, Hannes Reinecke <hare@...e.de>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org Subject: Re: [PATCH -next] memstick: remove set but not used variable 'data' On Thu, 11 Apr 2019 at 04:48, YueHaibing <yuehaibing@...wei.com> wrote: > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/memstick/host/jmb38x_ms.c: In function 'jmb38x_ms_issue_cmd': > drivers/memstick/host/jmb38x_ms.c:371:17: warning: > variable 'data' set but not used [-Wunused-but-set-variable] > > It's never used since introduction and can be removed. > Signed-off-by: YueHaibing <yuehaibing@...wei.com> Applied for next (to my mmc tree), thanks! Next time, please post to linux-mmc as well. Kind regards Uffe > --- > drivers/memstick/host/jmb38x_ms.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/memstick/host/jmb38x_ms.c b/drivers/memstick/host/jmb38x_ms.c > index e3a5af65dbce..acec09813419 100644 > --- a/drivers/memstick/host/jmb38x_ms.c > +++ b/drivers/memstick/host/jmb38x_ms.c > @@ -368,7 +368,6 @@ static int jmb38x_ms_transfer_data(struct jmb38x_ms_host *host) > static int jmb38x_ms_issue_cmd(struct memstick_host *msh) > { > struct jmb38x_ms_host *host = memstick_priv(msh); > - unsigned char *data; > unsigned int data_len, cmd, t_val; > > if (!(STATUS_HAS_MEDIA & readl(host->addr + STATUS))) { > @@ -400,8 +399,6 @@ static int jmb38x_ms_issue_cmd(struct memstick_host *msh) > cmd |= TPC_WAIT_INT; > } > > - data = host->req->data; > - > if (!no_dma) > host->cmd_flags |= DMA_DATA; > > >
Powered by blists - more mailing lists