linux-kernel - RE: [RESEND][PATCH v2] firmware/psci: add support for SYSTEM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM0PR07MB6019AB10C7DD38F7AFECF0E0F42F0@AM0PR07MB6019.eurprd07.prod.outlook.com>
Date:   Thu, 11 Apr 2019 11:42:28 +0000
From:   "Koskinen, Aaro (Nokia - FI/Espoo)" <aaro.koskinen@...ia.com>
To:     Sudeep Holla <sudeep.holla@....com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     Aaro Koskinen <aaro.koskinen@....fi>,
        Florian Fainelli <f.fainelli@...il.com>,
        Michal Simek <michal.simek@...inx.com>,
        Mark Rutland <mark.rutland@....com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>
Subject: RE: [RESEND][PATCH v2] firmware/psci: add support for SYSTEM_RESET2

Hi,

From: Sudeep Holla [sudeep.holla@....com]:
>  static void psci_sys_reset(enum reboot_mode reboot_mode, const char *cmd)
>  {
> +       if ((reboot_mode == REBOOT_WARM || reboot_mode == REBOOT_SOFT) &&

I would omit the REBOOT_SOFT here.

> +           psci_system_reset2_supported)
> +               /*
> +                * reset_type[31] = 0 (architectural)
> +                * reset_type[30:0] = 0 (SYSTEM_WARM_RESET)
> +                * cookie = 0 (ignored by the implementation)
> +                */
> +               invoke_psci_fn(PSCI_FN_NATIVE(1_1, SYSTEM_RESET2), 0, 0, 0);
> +
>        invoke_psci_fn(PSCI_0_2_FN_SYSTEM_RESET, 0, 0, 0);

Use else here, so that we fall back to system halt if SYSTEM_RESET2 fails.

A.