linux-kernel - Re: [PATCH] KVM: x86: avoid misreporting level-triggered irqs as edge-triggered in tracing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2cfda6e3-8979-6f38-4b20-99ad6d1d0c90@redhat.com>
Date:   Thu, 11 Apr 2019 15:14:53 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Vitaly Kuznetsov <vkuznets@...hat.com>, kvm@...r.kernel.org
Cc:     Radim Krčmář <rkrcmar@...hat.com>,
        Liran Alon <liran.alon@...cle.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] KVM: x86: avoid misreporting level-triggered irqs as
 edge-triggered in tracing

On 27/03/19 15:12, Vitaly Kuznetsov wrote:
> In __apic_accept_irq() interface trig_mode is int and actually on some code
> paths it is set above u8:
> 
> kvm_apic_set_irq() extracts it from 'struct kvm_lapic_irq' where trig_mode
> is u16. This is done on purpose as e.g. kvm_set_msi_irq() sets it to
> (1 << 15) & e->msi.data
> 
> kvm_apic_local_deliver sets it to reg & (1 << 15).
> 
> Fix the immediate issue by making 'tm' into u16. We may also want to adjust
> __apic_accept_irq() interface and use proper sizes for vector, level,
> trig_mode but this is not urgent.
> 
> Signed-off-by: Vitaly Kuznetsov <vkuznets@...hat.com>
> ---
>  arch/x86/kvm/trace.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/kvm/trace.h b/arch/x86/kvm/trace.h
> index 6432d08c7de7..4d47a2631d1f 100644
> --- a/arch/x86/kvm/trace.h
> +++ b/arch/x86/kvm/trace.h
> @@ -438,13 +438,13 @@ TRACE_EVENT(kvm_apic_ipi,
>  );
>  
>  TRACE_EVENT(kvm_apic_accept_irq,
> -	    TP_PROTO(__u32 apicid, __u16 dm, __u8 tm, __u8 vec),
> +	    TP_PROTO(__u32 apicid, __u16 dm, __u16 tm, __u8 vec),
>  	    TP_ARGS(apicid, dm, tm, vec),
>  
>  	TP_STRUCT__entry(
>  		__field(	__u32,		apicid		)
>  		__field(	__u16,		dm		)
> -		__field(	__u8,		tm		)
> +		__field(	__u16,		tm		)
>  		__field(	__u8,		vec		)
>  	),
>  
> 

Queued, thanks.

Paolo